mount module can't update flags on a mounted FS on OpenBSD

[landryb]

ISSUE TYPE

• Bug Report

COMPONENT NAME

mount module

ANSIBLE VERSION

ansible 2.2.0.0

CONFIGURATION

OS / ENVIRONMENT

OpenBSD

SUMMARY

https://github.com/ansible/ansible-modules-core/blob/devel/system/mount.py#L319 uses -o remount, which doesn't exist on OpenBSD. if you try to update the flags for an existing mountpoint, it will update fstab correctly, but then will try to remount/update the flags on the living FS, and mount module will fail.

STEPS TO REPRODUCE

#grep local /etc/fstab                                                                                       
/dev/wd0g /usr/local ffs rw,wxallowed 0 0

#ansible master -m mount -a 'name=/usr/local opts=rw,wxallowed,nosuid state=mounted fstype=ffs src=/dev/wd0g'
master | FAILED! => {
    "changed": false, 
    "failed": true, 
    "msg": "Error mounting /usr/local: mount_ffs: -o remount: option not supported\n"
}
#grep local /etc/fstab                                                                                       
/dev/wd0g /usr/local ffs rw,wxallowed,nosuid 0 0
#mount |grep /usr/local
/dev/wd0g on /usr/local type ffs (local, wxallowed)

EXPECTED RESULTS

the living FS should have seen its opts updated.

ACTUAL RESULTS

mount module failed... a possible fix would be to use mount -u which is more or less the equivalent of mount -o remount

#mount -u -o nosuid /usr/local
#mount |grep /usr/local       
/dev/wd0g on /usr/local type ffs (local, nosuid, wxallowed)

[ansibot]

@ansible ping, this issue is waiting for your response.
click here for bot help

[jctanner]

The relevant commit is a backport of a different patch
d843204

[landryb]

The relevant commit is a backport of a different patch
d843204

Interesting, but that still uses -o remount...

[abadger]

This should be fixed by the inclusion of these two PRs: #2445 #5673

if you can confirm that latest devel or latest stable-2.2 work, that would be great. If you can't I'll close this in a few days. It works with my tests on FreeBSD (which also uses -u for remount).

needs_info

[landryb]

Tried with 2.2.1.0-0.1.rc1 (not sure it has those two PRs), there's no error message, but the living FS isn't updated.

before:

$mount|grep sd0d ; grep sd0d /etc/fstab  
/dev/sd0d on /home type ffs (local, nodev, nosuid)
/dev/sd0d /home ffs rw,nodev,nosuid 1 2

ansible invocation with local connection:

$doas ansible -vvvv -c local localhost -m mount -a 'name=/home opts=rw,nodev,nosuid,wxallowed state=mounted fstype=ffs src=/dev/sd0d dump=1 passno=2'

Using /etc/ansible/ansible.cfg as config file
 [WARNING]: provided hosts list is empty, only localhost is available

Loading callback plugin minimal of type stdout, v2.0 from /usr/local/lib/python2.7/site-packages/ansible/plugins/callback/__init__.pyc
Using module file /usr/local/lib/python2.7/site-packages/ansible/modules/core/system/mount.py
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: landry
<127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo $HOME/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670 `" && echo ansible-tmp-1479806309.65-74141033850670="` echo $HOME/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670 `" ) && sleep 0'
<127.0.0.1> PUT /tmp/tmp2QsDsI TO /home/landry/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670/mount.py
<127.0.0.1> EXEC /bin/sh -c 'chmod u+x /home/landry/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670/ /home/landry/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670/mount.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '/usr/local/bin/python2.7 /home/landry/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670/mount.py; rm -rf "/home/landry/.ansible/tmp/ansible-tmp-1479806309.65-74141033850670/" > /dev/null 2>&1 && sleep 0'
localhost | SUCCESS => {
    "changed": true, 
    "dump": "1", 
    "fstab": "/etc/fstab", 
    "fstype": "ffs", 
    "invocation": {
        "module_args": {
            "boot": "yes", 
            "dump": "1", 
            "fstab": "/etc/fstab", 
            "fstype": "ffs", 
            "name": "/home", 
            "opts": "rw,nodev,nosuid,wxallowed", 
            "passno": "2", 
            "src": "/dev/sd0d", 
            "state": "mounted"
        }, 
        "module_name": "mount"
    }, 
    "name": "/home", 
    "opts": "rw,nodev,nosuid,wxallowed", 
    "passno": "2", 
    "src": "/dev/sd0d"
}

after:

$mount|grep sd0d ; grep sd0d /etc/fstab                                              
/dev/sd0d on /home type ffs (local, nodev, nosuid)
/dev/sd0d /home ffs rw,nodev,nosuid,wxallowed 1 2

[landryb]

According to https://github.com/ansible/ansible-modules-core/commits/stable-2.2 2.2.1.0-0.1.rc1 should have those two PRs, so.. i'm puzzled.

[landryb]

Same thing using -b --become-method=doas instead of doas ansible

[abadger]

@landryb What happens if you run "doas mount -u -F/etc/fstab /dev/sd0d" (which is what ansible is going to attempt first to remount on openbsd)?