Bug 1957443 [wpt PR 51720] - [shared storage] Validate that batchUpdate() cannot contain inner method locks, a=testonly

yaoxiachromium · moz-wptsync-bot · commit 6c200c64c418 · 2025-04-03T09:43:28.000Z
Automatic update from web-platform-tests [shared storage] Validate that batchUpdate() cannot contain inner method locks As part of the transactional batchUpdate() proposal (spec PR:[1]), inner method locks are no longer permitted. This CL implements validation in both the caller code and mojom traits. Note that while unrecognized IDL dictionary fields are generally allowed, strict validation is enforced for this deprecated 'withLock' field to prevent potential misuse. [1] WICG/shared-storage#231 Bug: 404568020 Change-Id: I9dbc395445342a34a68f12b31fdc285a7576787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6393777 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1440291} -- wpt-commits: 86858ee83ee8acec885b42923b656a61fde7f257 wpt-pr: 51720
diff --git a/testing/web-platform/tests/shared-storage/batch-update-inner-method-lock-not-allowed.tentative.https.sub.html b/testing/web-platform/tests/shared-storage/batch-update-inner-method-lock-not-allowed.tentative.https.sub.html
@@ -0,0 +1,17 @@
+<!doctype html>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+
+<body>
+<script>
+'use strict';
+
+promise_test(async t => {
+  return promise_rejects_dom(t, "DataError",
+    sharedStorage.batchUpdate([
+      new SharedStorageSetMethod("key0", "value0", {withLock: "lock1"})
+    ]));
+}, 'batchUpdate() with a set method that specifies the \'withLock\' option');
+
+</script>
+</body>
diff --git a/testing/web-platform/tests/shared-storage/setters.tentative.https.sub.html b/testing/web-platform/tests/shared-storage/setters.tentative.https.sub.html
@@ -106,10 +106,10 @@
 
 promise_test(() => {
   return sharedStorage.batchUpdate([
-    new SharedStorageSetMethod("key0", "value0", {withLock: "lock1"}),
+    new SharedStorageSetMethod("key0", "value0"),
     new SharedStorageAppendMethod("key1", "value1"),
     new SharedStorageDeleteMethod("key2"),
-    new SharedStorageClearMethod({withLock: "lock2"})
+    new SharedStorageClearMethod()
   ], {withLock: "lock3"});
 }, 'sharedStorage.batchUpdate');
 
diff --git a/testing/web-platform/tests/shared-storage/web-locks-header-modifier-method.tentative.https.sub.html b/testing/web-platform/tests/shared-storage/web-locks-header-modifier-method.tentative.https.sub.html
