minor: Add PhysicalSortExpr::new (#11310)

* Add PhysicalSortExpr::new

* update call sites in physical-expr-common crate

Author: andygrove

datafusion/physical-expr-common/src/sort_expr.rs

@@ -39,6 +39,13 @@ pub struct PhysicalSortExpr {
     pub options: SortOptions,
 }
 
+impl PhysicalSortExpr {
+    /// Create a new PhysicalSortExpr
+    pub fn new(expr: Arc<dyn PhysicalExpr>, options: SortOptions) -> Self {
+        Self { expr, options }
+    }
+}
+
 impl PartialEq for PhysicalSortExpr {
     fn eq(&self, other: &PhysicalSortExpr) -> bool {
         self.options == other.options && self.expr.eq(&other.expr)
@@ -155,10 +162,7 @@ impl From<PhysicalSortRequirement> for PhysicalSortExpr {
             descending: false,
             nulls_first: false,
         });
-        PhysicalSortExpr {
-            expr: value.expr,
-            options,
-        }
+        PhysicalSortExpr::new(value.expr, options)
     }
 }
 
@@ -281,16 +285,13 @@ pub fn limited_convert_logical_sort_exprs_to_physical(
         let Expr::Sort(sort) = expr else {
             return exec_err!("Expects to receive sort expression");
         };
-        sort_exprs.push(PhysicalSortExpr {
-            expr: limited_convert_logical_expr_to_physical_expr(
-                sort.expr.as_ref(),
-                schema,
-            )?,
-            options: SortOptions {
+        sort_exprs.push(PhysicalSortExpr::new(
+            limited_convert_logical_expr_to_physical_expr(sort.expr.as_ref(), schema)?,
+            SortOptions {
                 descending: !sort.asc,
                 nulls_first: sort.nulls_first,
             },
-        });
+        ))
     }
     Ok(sort_exprs)
 }

datafusion/physical-expr-common/src/utils.rs

@@ -104,10 +104,7 @@ pub fn scatter(mask: &BooleanArray, truthy: &dyn Array) -> Result<ArrayRef> {
 pub fn reverse_order_bys(order_bys: &[PhysicalSortExpr]) -> Vec<PhysicalSortExpr> {
     order_bys
         .iter()
-        .map(|e| PhysicalSortExpr {
-            expr: e.expr.clone(),
-            options: !e.options,
-        })
+        .map(|e| PhysicalSortExpr::new(e.expr.clone(), !e.options))
         .collect()
 }