diff --git a/dev-support/bin/hadoop.sh b/dev-support/bin/hadoop.sh index c60603334febb..fd9363e66bbd7 100755 --- a/dev-support/bin/hadoop.sh +++ b/dev-support/bin/hadoop.sh @@ -577,7 +577,6 @@ function shadedclient_rebuild extra=( "-Dtest=NoUnitTests" - "-Dsurefire.failIfNoSpecifiedTests=false" "-Dmaven.javadoc.skip=true" "-Dcheckstyle.skip=true" "-Dspotbugs.skip=true" @@ -615,7 +614,7 @@ function shadedclient_rebuild echo_and_redirect "${logfile}" \ "${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \ "${modules[@]}" \ - -DskipShade -Dtest=NoUnitTests -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ + -DskipShade -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true \ -Dspotbugs.skip=true ${extra[*]} count=$("${GREP}" -c '\[ERROR\]' "${logfile}") diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java index b313a8737fab0..22115ff0a938c 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java @@ -1806,7 +1806,6 @@ protected LocatedBlock nextBlockOutputStream() throws IOException { do { errorState.resetInternalError(); lastException.clear(); - DatanodeInfo[] excluded = getExcludedNodes(); lb = locateFollowingBlock( excluded.length > 0 ? excluded : null, oldBlock); @@ -1849,6 +1848,7 @@ boolean createBlockOutputStream(DatanodeInfo[] nodes, LOG.info("nodes are empty for write pipeline of " + block); return false; } + String firstBadLink = ""; boolean checkRestart = false; if (LOG.isDebugEnabled()) { diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java index 79b4bbadce9c1..6208d68283e07 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java @@ -89,6 +89,7 @@ private LocatedBlock getFollowingBlock() throws IOException { return coordinator.getFollowingBlocks().poll(index); } + @Override protected LocatedBlock nextBlockOutputStream() throws IOException { boolean success; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java index 38b03f8d6a24d..e0acc9d3f32de 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java @@ -148,6 +148,7 @@ class BlockReceiver implements Closeable { private final AtomicLong lastSentTime = new AtomicLong(0L); private long maxSendIdleTime; + BlockReceiver(final ExtendedBlock block, final StorageType storageType, final DataInputStream in, final String inAddr, final String myAddr, diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java index 4ab7e1be84523..e341da28c2f78 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java @@ -96,6 +96,7 @@ public boolean isSimulated() { } } + /** * It behaviors as an unmodifiable list of FsVolume. Individual FsVolume can * be obtained by using {@link #get(int)}. diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java index b1526c9860e94..acf4323f69a83 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java @@ -1583,6 +1583,7 @@ public Replica recoverClose(ExtendedBlock b, long newGS, } } + @Override // FsDatasetSpi public ReplicaHandler createRbw( StorageType storageType, String storageId, ExtendedBlock b, diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java index 8eb048c14235c..ca982068982a2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java @@ -150,7 +150,8 @@ public class TestDistributedFileSystem { private boolean dualPortTesting = false; private boolean noXmlDefaults = false; - + + HdfsConfiguration getTestConfiguration() { HdfsConfiguration conf; if (noXmlDefaults) { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java index 5421393c9e675..1c2de86057770 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java @@ -104,6 +104,7 @@ public SimulatedFSDataset newInstance(DataNode datanode, return new SimulatedFSDataset(datanode, storage, conf); } + @Override public boolean isSimulated() { return true; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java index 86d4319913301..46129f2a16ca1 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java @@ -54,6 +54,7 @@ public class ExternalDatasetImpl implements FsDatasetSpi { DatanodeStorage.generateUuid(), DatanodeStorage.State.NORMAL, StorageType.DEFAULT); + @Override public FsVolumeReferences getFsVolumeReferences() { return null; diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml index a344b562b9519..3086e74969981 100644 --- a/hadoop-project/pom.xml +++ b/hadoop-project/pom.xml @@ -169,7 +169,7 @@ -Xmx2048m -XX:+HeapDumpOnOutOfMemoryError - 3.2.5 + 3.0.0-M1 ${maven-surefire-plugin.version} ${maven-surefire-plugin.version}