Skip to content

Commit 33ee549

Browse files
nandorKollargszadovszky
authored andcommitted
PARQUET-1335: Logical type names in parquet-mr are not consistent with parquet-format (#496)
1 parent cc8bdf1 commit 33ee549

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ protected LogicalTypeAnnotation fromString(List<String> params) {
4141
return listType();
4242
}
4343
},
44-
UTF8 {
44+
STRING {
4545
@Override
4646
protected LogicalTypeAnnotation fromString(List<String> params) {
4747
return stringType();
@@ -92,7 +92,7 @@ protected LogicalTypeAnnotation fromString(List<String> params) {
9292
return timestampType(Boolean.parseBoolean(params.get(1)), TimeUnit.valueOf(params.get(0)));
9393
}
9494
},
95-
INT {
95+
INTEGER {
9696
@Override
9797
protected LogicalTypeAnnotation fromString(List<String> params) {
9898
if (params.size() != 2) {
@@ -277,7 +277,7 @@ public <T> Optional<T> accept(LogicalTypeAnnotationVisitor<T> logicalTypeAnnotat
277277

278278
@Override
279279
LogicalTypeToken getType() {
280-
return LogicalTypeToken.UTF8;
280+
return LogicalTypeToken.STRING;
281281
}
282282

283283
@Override
@@ -650,7 +650,7 @@ public <T> Optional<T> accept(LogicalTypeAnnotationVisitor<T> logicalTypeAnnotat
650650

651651
@Override
652652
LogicalTypeToken getType() {
653-
return LogicalTypeToken.INT;
653+
return LogicalTypeToken.INTEGER;
654654
}
655655

656656
@Override

parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
public class TestParquetParser {
4949
@Test
50-
public void testPaperExample() throws Exception {
50+
public void testPaperExample() {
5151
String example =
5252
"message Document {\n" +
5353
" required int64 DocId;\n" +
@@ -122,7 +122,7 @@ public void testEachPrimitiveType() {
122122
public void testUTF8Annotation() {
123123
String message =
124124
"message StringMessage {\n" +
125-
" required binary string (UTF8);\n" +
125+
" required binary string (STRING);\n" +
126126
"}\n";
127127

128128
MessageType parsed = parseMessageType(message);
@@ -139,7 +139,7 @@ public void testUTF8Annotation() {
139139
public void testIDs() {
140140
String message =
141141
"message Message {\n" +
142-
" required binary string (UTF8) = 6;\n" +
142+
" required binary string (STRING) = 6;\n" +
143143
" required int32 i=1;\n" +
144144
" required binary s2= 3;\n" +
145145
" required binary s3 =4;\n" +
@@ -165,7 +165,7 @@ public void testMAPAnnotations() {
165165
"message Message {\n" +
166166
" optional group aMap (MAP) {\n" +
167167
" repeated group map (MAP_KEY_VALUE) {\n" +
168-
" required binary key (UTF8);\n" +
168+
" required binary key (STRING);\n" +
169169
" required int32 value;\n" +
170170
" }\n" +
171171
" }\n" +
@@ -192,7 +192,7 @@ public void testLISTAnnotation() {
192192
String message =
193193
"message Message {\n" +
194194
" required group aList (LIST) {\n" +
195-
" repeated binary string (UTF8);\n" +
195+
" repeated binary string (STRING);\n" +
196196
" }\n" +
197197
"}\n";
198198

@@ -304,14 +304,14 @@ public void testIntAnnotations() {
304304
@Test
305305
public void testIntegerAnnotations() {
306306
String message = "message IntMessage {" +
307-
" required int32 i8 (INT(8,true));" +
308-
" required int32 i16 (INT(16,true));" +
309-
" required int32 i32 (INT(32,true));" +
310-
" required int64 i64 (INT(64,true));" +
311-
" required int32 u8 (INT(8,false));" +
312-
" required int32 u16 (INT(16,false));" +
313-
" required int32 u32 (INT(32,false));" +
314-
" required int64 u64 (INT(64,false));" +
307+
" required int32 i8 (INTEGER(8,true));" +
308+
" required int32 i16 (INTEGER(16,true));" +
309+
" required int32 i32 (INTEGER(32,true));" +
310+
" required int64 i64 (INTEGER(64,true));" +
311+
" required int32 u8 (INTEGER(8,false));" +
312+
" required int32 u16 (INTEGER(16,false));" +
313+
" required int32 u32 (INTEGER(32,false));" +
314+
" required int64 u64 (INTEGER(64,false));" +
315315
"}\n";
316316

317317
MessageType parsed = MessageTypeParser.parseMessageType(message);

0 commit comments

Comments
 (0)