diff --git a/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java b/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java index 2090af4fbf2..d3513444462 100644 --- a/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java +++ b/seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/client/ActivemqClient.java @@ -63,10 +63,11 @@ public ActivemqClient(ReadonlyConfig config) { log.info("connection created"); } catch (Exception e) { - e.printStackTrace(); + log.error("Error while creating AMQ client", e); throw new ActivemqConnectorException( ActivemqConnectorErrorCode.CREATE_ACTIVEMQ_CLIENT_FAILED, - "Error while create AMQ client "); + "Error while create AMQ client ", + e); } } diff --git a/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java b/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java index 6c6631ce103..bae1329353b 100644 --- a/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java +++ b/seatunnel-connectors-v2/connector-graphql/src/main/java/org/apache/seatunnel/connectors/seatunnel/graphql/source/reader/GraphQLWebSocket.java @@ -98,8 +98,7 @@ public void onClosing(@NotNull WebSocket webSocket, int code, @NotNull String re @Override public void onFailure( @NotNull WebSocket webSocket, @NotNull Throwable t, @Nullable Response response) { - log.error("WebSocket connection failed: " + t.getMessage()); - t.printStackTrace(); + log.error("WebSocket connection failed", t); scheduleReconnect(); } @@ -108,7 +107,8 @@ public void onMessage(@NotNull WebSocket webSocket, @NotNull String text) { try { buffer.put(text); } catch (InterruptedException e) { - e.printStackTrace(); + log.error("Failed to put message into buffer", e); + Thread.currentThread().interrupt(); } } @@ -139,7 +139,8 @@ private void scheduleReconnect() { Thread.sleep(RETRY_DELAY_MS); connect(); } catch (InterruptedException e) { - e.printStackTrace(); + log.error("Reconnection attempt interrupted", e); + Thread.currentThread().interrupt(); } }) .start(); diff --git a/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java b/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java index 6d6043fea50..933c703225e 100644 --- a/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java +++ b/seatunnel-connectors-v2/connector-sls/src/main/java/org/apache/seatunnel/connectors/seatunnel/sls/sink/SlsSinkWriter.java @@ -77,8 +77,7 @@ public void write(SeaTunnelRow element) throws IOException { try { this.client.PutLogs(plr); } catch (Throwable e) { - log.error("write logs failed", e); - e.printStackTrace(); + log.error("Failed to write logs to SLS", e); throw new IOException(e); } }