address comment

Author: mgaido91

core/src/main/scala/org/apache/spark/internal/config/Tests.scala

@@ -18,6 +18,9 @@
 package org.apache.spark.internal.config
 
 private[spark] object Tests {
+
+  val TEST_USE_COMPRESSED_OOPS_KEY = "spark.test.useCompressedOops"
+
   val TEST_MEMORY = ConfigBuilder("spark.testing.memory")
     .longConf
     .createWithDefault(Runtime.getRuntime.maxMemory)
@@ -31,10 +34,6 @@ private[spark] object Tests {
     .booleanConf
     .createOptional
 
-  val TEST_USE_COMPRESSED_OOPS = ConfigBuilder("spark.test.useCompressedOops")
-    .booleanConf
-    .createOptional
-
   val TEST_NO_STAGE_RETRY = ConfigBuilder("spark.test.noStageRetry")
     .booleanConf
     .createWithDefault(false)

core/src/main/scala/org/apache/spark/util/SizeEstimator.scala

@@ -28,7 +28,7 @@ import com.google.common.collect.MapMaker
 
 import org.apache.spark.annotation.DeveloperApi
 import org.apache.spark.internal.Logging
-import org.apache.spark.internal.config.Tests.TEST_USE_COMPRESSED_OOPS
+import org.apache.spark.internal.config.Tests.TEST_USE_COMPRESSED_OOPS_KEY
 import org.apache.spark.util.collection.OpenHashSet
 
 /**
@@ -127,8 +127,8 @@ object SizeEstimator extends Logging {
   private def getIsCompressedOops: Boolean = {
     // This is only used by tests to override the detection of compressed oops. The test
     // actually uses a system property instead of a SparkConf, so we'll stick with that.
-    if (System.getProperty(TEST_USE_COMPRESSED_OOPS.key) != null) {
-      return System.getProperty(TEST_USE_COMPRESSED_OOPS.key).toBoolean
+    if (System.getProperty(TEST_USE_COMPRESSED_OOPS_KEY) != null) {
+      return System.getProperty(TEST_USE_COMPRESSED_OOPS_KEY).toBoolean
     }
 
     // java.vm.info provides compressed ref info for IBM JDKs

core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala

@@ -120,7 +120,6 @@ class BlockManagerSuite extends SparkFunSuite with Matchers with BeforeAndAfterE
       .set("spark.memory.fraction", "1")
       .set("spark.memory.storageFraction", "1")
       .set("spark.kryoserializer.buffer", "1m")
-      .set(TEST_USE_COMPRESSED_OOPS, true)
       .set("spark.storage.unrollFraction", "0.4")
       .set("spark.storage.unrollMemoryThreshold", "512")
 

core/src/test/scala/org/apache/spark/storage/MemoryStoreSuite.scala

@@ -40,7 +40,6 @@ class MemoryStoreSuite
   with ResetSystemProperties {
 
   var conf: SparkConf = new SparkConf(false)
-    .set(TEST_USE_COMPRESSED_OOPS, true)
     .set("spark.storage.unrollFraction", "0.4")
     .set("spark.storage.unrollMemoryThreshold", "512")
 

core/src/test/scala/org/apache/spark/util/SizeEstimatorSuite.scala

@@ -22,7 +22,7 @@ import scala.collection.mutable.ArrayBuffer
 import org.scalatest.{BeforeAndAfterEach, PrivateMethodTester}
 
 import org.apache.spark.SparkFunSuite
-import org.apache.spark.internal.config.Tests.TEST_USE_COMPRESSED_OOPS
+import org.apache.spark.internal.config.Tests.TEST_USE_COMPRESSED_OOPS_KEY
 
 class DummyClass1 {}
 
@@ -77,7 +77,7 @@ class SizeEstimatorSuite
     // Set the arch to 64-bit and compressedOops to true to get a deterministic test-case
     super.beforeEach()
     System.setProperty("os.arch", "amd64")
-    System.setProperty(TEST_USE_COMPRESSED_OOPS.key, "true")
+    System.setProperty(TEST_USE_COMPRESSED_OOPS_KEY, "true")
   }
 
   override def afterEach(): Unit = {
@@ -193,7 +193,7 @@ class SizeEstimatorSuite
   // (Sun vs IBM). Use a DummyString class to make tests deterministic.
   test("64-bit arch with no compressed oops") {
     System.setProperty("os.arch", "amd64")
-    System.setProperty(TEST_USE_COMPRESSED_OOPS.key, "false")
+    System.setProperty(TEST_USE_COMPRESSED_OOPS_KEY, "false")
     val initialize = PrivateMethod[Unit]('initialize)
     SizeEstimator invokePrivate initialize()