address feedback

dbtsai · dbtsai · commit 5f1cc661d9b0 · 2018-12-19T17:12:07.000-08:00
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
@@ -37,7 +37,7 @@ object Canonicalize {
     expressionReorder(ignoreNamesTypes(e))
   }
 
-  /** Remove names and nullability from types. */
+  /** Remove names and/or nullability from types. */
   private[expressions] def ignoreNamesTypes(e: Expression): Expression = e match {
     case a: AttributeReference =>
       AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ object Canonicalize {`
`37`	`37`	`expressionReorder(ignoreNamesTypes(e))`
`38`	`38`	`}`
`39`	`39`
`40`		`- /** Remove names and nullability from types. */`
	`40`	`+ /** Remove names and/or nullability from types. */`
`41`	`41`	`private[expressions] def ignoreNamesTypes(e: Expression): Expression = e match {`
`42`	`42`	`case a: AttributeReference =>`
`43`	`43`	`AttributeReference("none", a.dataType.asNullable)(exprId = a.exprId)`