remove todos, set ansi enabled

Author: peter-toth

sql/core/src/test/resources/sql-tests/inputs/pgSQL/with.sql

@@ -244,9 +244,8 @@ INSERT INTO department VALUES (7, 5, 'G');
 --	SELECT * FROM subdepartment;
 --
 --SELECT * FROM vsubdepartment ORDER BY name;
-
--- Check reverse listing
--- [TODO] is there a way to show DDL of a view?
+--
+---- Check reverse listing
 --SELECT pg_get_viewdef('vsubdepartment'::regclass);
 --SELECT pg_get_viewdef('vsubdepartment'::regclass, true);
 
@@ -259,8 +258,7 @@ INSERT INTO department VALUES (7, 5, 'G');
 --    SELECT n+1 FROM t WHERE n < 100
 --)
 --SELECT sum(n) FROM t;
-
--- [TODO] is there a way to show DDL of a view?
+--
 --\d+ sums_1_100
 
 -- corner case in which sub-WITH gets initialized first
@@ -465,10 +463,10 @@ INSERT INTO y SELECT EXPLODE(SEQUENCE(1, 10));
 --SELECT * FROM y;
 
 -- [NOTE] Spark SQL doesn't support UPDATE statement
-----WITH t AS (
-----	SELECT a FROM y
-----)
-----UPDATE y SET a = y.a-10 FROM t WHERE y.a > 20 AND t.a = y.a RETURNING y.a;
+--WITH t AS (
+--	SELECT a FROM y
+--)
+--UPDATE y SET a = y.a-10 FROM t WHERE y.a > 20 AND t.a = y.a RETURNING y.a;
 --
 --SELECT * FROM y;
 
@@ -1184,10 +1182,10 @@ SELECT * FROM parent;
 --DROP RULE y_rule ON y;
 
 -- check that parser lookahead for WITH doesn't cause any odd behavior
--- [TODO] WITH should be a reserved keyword?
+set spark.sql.parser.ansi.enabled=true;
 create table foo (with baz);  -- fail, WITH is a reserved word
--- [TODO] WITH should be a reserved keyword?
 create table foo (with ordinality);  -- fail, WITH is a reserved word
+set spark.sql.parser.ansi.enabled=false;
 with ordinality as (select 1 as x) select * from ordinality;
 
 -- check sane response to attempt to modify CTE relation

sql/core/src/test/resources/sql-tests/results/pgSQL/with.sql.out

@@ -1,5 +1,5 @@
 -- Automatically generated by SQLQueryTestSuite
--- Number of queries: 52
+-- Number of queries: 54
 
 
 -- !query 0
@@ -352,128 +352,144 @@ struct<id:int,val:string>
 
 
 -- !query 38
-create table foo (with baz)
+set spark.sql.parser.ansi.enabled=true
 -- !query 38 schema
-struct<>
+struct<key:string,value:string>
 -- !query 38 output
-org.apache.spark.sql.catalyst.parser.ParseException
-
-DataType baz is not supported.(line 1, pos 23)
-
-== SQL ==
-create table foo (with baz)
------------------------^^^
+spark.sql.parser.ansi.enabled	true
 
 
 -- !query 39
--- fail, WITH is a reserved word
-create table foo (with ordinality)
+create table foo (with baz)
 -- !query 39 schema
 struct<>
 -- !query 39 output
 org.apache.spark.sql.catalyst.parser.ParseException
 
-DataType ordinality is not supported.(line 2, pos 23)
+no viable alternative at input 'with'(line 1, pos 18)
 
 == SQL ==
--- fail, WITH is a reserved word
-create table foo (with ordinality)
------------------------^^^
+create table foo (with baz)
+------------------^^^
 
 
 -- !query 40
 -- fail, WITH is a reserved word
-with ordinality as (select 1 as x) select * from ordinality
+create table foo (with ordinality)
 -- !query 40 schema
-struct<x:int>
+struct<>
 -- !query 40 output
-1
+org.apache.spark.sql.catalyst.parser.ParseException
+
+no viable alternative at input 'with'(line 2, pos 18)
+
+== SQL ==
+-- fail, WITH is a reserved word
+create table foo (with ordinality)
+------------------^^^
 
 
 -- !query 41
-WITH test AS (SELECT 42) INSERT INTO test VALUES (1)
+-- fail, WITH is a reserved word
+set spark.sql.parser.ansi.enabled=false
 -- !query 41 schema
-struct<>
+struct<key:string,value:string>
 -- !query 41 output
-org.apache.spark.sql.AnalysisException
-Table not found: test;
+spark.sql.parser.ansi.enabled	false
 
 
 -- !query 42
-create table test (i int) USING parquet
+with ordinality as (select 1 as x) select * from ordinality
 -- !query 42 schema
-struct<>
+struct<x:int>
 -- !query 42 output
-
+1
 
 
 -- !query 43
-with test as (select 42) insert into test select * from test
+WITH test AS (SELECT 42) INSERT INTO test VALUES (1)
 -- !query 43 schema
 struct<>
 -- !query 43 output
-
+org.apache.spark.sql.AnalysisException
+Table not found: test;
 
 
 -- !query 44
-select * from test
+create table test (i int) USING parquet
 -- !query 44 schema
-struct<i:int>
+struct<>
 -- !query 44 output
-42
+
 
 
 -- !query 45
-drop table test
+with test as (select 42) insert into test select * from test
 -- !query 45 schema
 struct<>
 -- !query 45 output
 
 
 
 -- !query 46
-DROP TABLE department
+select * from test
 -- !query 46 schema
-struct<>
+struct<i:int>
 -- !query 46 output
-
+42
 
 
 -- !query 47
-DROP TABLE tree
+drop table test
 -- !query 47 schema
 struct<>
 -- !query 47 output
 
 
 
 -- !query 48
-DROP TABLE graph
+DROP TABLE department
 -- !query 48 schema
 struct<>
 -- !query 48 output
 
 
 
 -- !query 49
-DROP TABLE y
+DROP TABLE tree
 -- !query 49 schema
 struct<>
 -- !query 49 output
 
 
 
 -- !query 50
-DROP TABLE yy
+DROP TABLE graph
 -- !query 50 schema
 struct<>
 -- !query 50 output
 
 
 
 -- !query 51
-DROP TABLE parent
+DROP TABLE y
 -- !query 51 schema
 struct<>
 -- !query 51 output
 
+
+
+-- !query 52
+DROP TABLE yy
+-- !query 52 schema
+struct<>
+-- !query 52 output
+
+
+
+-- !query 53
+DROP TABLE parent
+-- !query 53 schema
+struct<>
+-- !query 53 output
+