Skip to content

Commit a3cce89

Browse files
committed
Fix
1 parent c17c5fb commit a3cce89

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ case class InMemoryRelation(
168168

169169
@transient val partitionStatistics = new PartitionStatistics(output)
170170

171-
val cachedPlan: SparkPlan = cacheBuilder.cachedPlan
171+
def cachedPlan: SparkPlan = cacheBuilder.cachedPlan
172172

173173
override def computeStats(): Statistics = {
174174
if (cacheBuilder.sizeInBytesStats.value == 0L) {

sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
796796
}
797797
}
798798

799-
private def checkIfNoJobTriggered(f: => DataFrame): DataFrame = {
799+
private def checkIfNoJobTriggered[T](f: => T): T = {
800800
var numJobTrigered = 0
801801
val jobListener = new SparkListener {
802802
override def onJobStart(jobStart: SparkListenerJobStart): Unit = {
@@ -805,18 +805,19 @@ class CachedTableSuite extends QueryTest with SQLTestUtils with SharedSQLContext
805805
}
806806
sparkContext.addSparkListener(jobListener)
807807
try {
808-
val df = f
808+
val result = f
809+
sparkContext.listenerBus.waitUntilEmpty(10000L)
809810
assert(numJobTrigered === 0)
810-
df
811+
result
811812
} finally {
812813
sparkContext.removeSparkListener(jobListener)
813814
}
814815
}
815816

816817
test("SPARK-23880 table cache should be lazy and don't trigger any jobs") {
817-
val cachedDf = checkIfNoJobTriggered {
818-
spark.range(3L).selectExpr("id", "id AS value").filter('id > 0).orderBy('id.asc).cache()
818+
val cachedData = checkIfNoJobTriggered {
819+
spark.range(1002).filter('id > 1000).orderBy('id.desc).cache()
819820
}
820-
checkAnswer(cachedDf, Row(1L, 1L) :: Row(2L, 2L) :: Nil)
821+
assert(cachedData.collect === Seq(1001))
821822
}
822823
}

0 commit comments

Comments
 (0)