Skip to content

Commit bbdb271

Browse files
committed
Use pattern match in createNullValue
1 parent b0a0e7e commit bbdb271

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,13 @@ private[spark] object ClosureCleaner extends Logging {
109109

110110
private def createNullValue(cls: Class[_]): AnyRef = {
111111
if (cls.isPrimitive) {
112-
if (cls == java.lang.Boolean.TYPE) {
113-
new java.lang.Boolean(false)
114-
} else if (cls == java.lang.Character.TYPE) {
115-
new java.lang.Character('\0')
116-
} else if (cls == java.lang.Void.TYPE) {
117-
// It should not happen because `Foo(void x) {}` won't be compiled.
118-
throw new IllegalStateException("This should not happen")
119-
} else {
120-
new java.lang.Byte(0: Byte)
112+
cls match {
113+
case java.lang.Boolean.TYPE => new java.lang.Boolean(false)
114+
case java.lang.Character.TYPE => new java.lang.Character('\0')
115+
case java.lang.Void.TYPE =>
116+
// This should not happen because `Foo(void x) {}` cannot be compiled.
117+
throw new IllegalStateException("This should not happen")
118+
case _ => new java.lang.Byte(0: Byte)
121119
}
122120
} else {
123121
null

0 commit comments

Comments
 (0)