Commit c9df53f
[SPARK-46241][PYTHON][CONNECT] Fix error handling routine so it wouldn't fall into infinite recursion
### What changes were proposed in this pull request?
Remove _display_server_stack_trace and always display error stack trace if we have one
### Why are the changes needed?
There is a certain codepath which can make existing error handling fall into infinite recursion. I.e. consider following codepath:
`[Some error happens] -> _handle_error -> _handle_rpc_error -> _display_server_stack_trace -> RuntimeConf.get -> SparkConnectClient.config -> [An error happens] -> _handle_error`.
There can be other similar codepaths
### Does this PR introduce _any_ user-facing change?
Gets rid of occasionally infinite recursive error handling (which can cause downgraded user experience)
### How was this patch tested?
N/A
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #44144 from cdkrot/forbid_recursive_error_handling.
Authored-by: Alice Sayutina <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>1 parent 89673da commit c9df53f
1 file changed
+1
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1520 | 1520 | | |
1521 | 1521 | | |
1522 | 1522 | | |
1523 | | - | |
1524 | | - | |
1525 | | - | |
1526 | | - | |
1527 | | - | |
1528 | | - | |
1529 | | - | |
1530 | | - | |
1531 | | - | |
1532 | | - | |
1533 | | - | |
1534 | | - | |
1535 | | - | |
1536 | | - | |
1537 | 1523 | | |
1538 | 1524 | | |
1539 | 1525 | | |
| |||
1567 | 1553 | | |
1568 | 1554 | | |
1569 | 1555 | | |
1570 | | - | |
| 1556 | + | |
1571 | 1557 | | |
1572 | 1558 | | |
1573 | 1559 | | |
| |||
0 commit comments