Skip to content

Commit d7653d6

Browse files
committed
Rename z to adjusted
1 parent f1485ca commit d7653d6

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

mllib/src/main/scala/org/apache/spark/ml/optim/GLMFamilies.scala

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,10 @@ private[ml] abstract class Family(val link: Link) extends Serializable {
3939
/** Weights for IRLS steps. */
4040
def weights(mu: Double): Double
4141

42-
/** The working dependent variable. */
43-
def z(y: Double, mu: Double, eta: Double): Double
42+
/** The adjusted response variable. */
43+
def adjusted(y: Double, mu: Double, eta: Double): Double = {
44+
eta + (y - mu) * link.deriv(mu)
45+
}
4446

4547
/** Linear predictors based on given mu. */
4648
def predict(mu: Double): Double = this.link.link(mu)
@@ -69,10 +71,6 @@ private[ml] class Binomial(link: Link = Logit) extends Family(link) {
6971
override def weights(mu: Double): Double = {
7072
mu * (1 - mu)
7173
}
72-
73-
override def z(y: Double, mu: Double, eta: Double): Double = {
74-
eta + (y - mu) * link.deriv(mu)
75-
}
7674
}
7775

7876
/**
@@ -89,10 +87,6 @@ private[ml] class Poisson(link: Link = Log) extends Family(link) {
8987
}
9088

9189
override def weights(mu: Double): Double = mu
92-
93-
override def z(y: Double, mu: Double, eta: Double): Double = {
94-
eta + (y - mu) / mu
95-
}
9690
}
9791

9892
/**

mllib/src/main/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquares.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private[ml] class IterativelyReweightedLeastSquares(
6767

6868
zw = y.zip(mu).map { case (y, mu) =>
6969
val eta = family.predict(mu)
70-
val z = family.z(y, mu, eta)
70+
val z = family.adjusted(y, mu, eta)
7171
val w = family.weights(mu)
7272
(z, w)
7373
}

0 commit comments

Comments
 (0)