Skip to content

Commit de960a5

Browse files
morvenhuangsrowen
authored andcommitted
[SPARK-38641][BUILD] Get rid of invalid configuration elements in mvn_scalafmt in main pom.xml
### What changes were proposed in this pull request? In main pom.xml, for mvn_scalafmt plugin, I removed 'parameters' since it's invalid , and replace 'skip' with 'validateOnly' since 'skip' is invalid too. ### Why are the changes needed? I think we should not leave invalid items there in the pom.xml I've contacted the author of mvn_scalafmt, Ciaran Kearney, to confirm if these 2 configuration items are no longer there since v 1.0.0, and he said: "That's correct. The command line parameters were removed by scalafmt itself a few versions ago and skip was replaced by validateOnly (which checks formatting without changing files." ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Run mvn-scalafmt_2.12:format locally via mvn. Closes #35956 from morvenhuang/SPARK-38641. Authored-by: morvenhuang <[email protected]> Signed-off-by: Sean Owen <[email protected]>
1 parent e410d98 commit de960a5

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

pom.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@
171171
-->
172172

173173
<scala-maven-plugin.version>4.5.6</scala-maven-plugin.version>
174-
<scalafmt.parameters>--test</scalafmt.parameters>
175174
<!-- for now, not running scalafmt as part of default verify pipeline -->
176175
<scalafmt.skip>true</scalafmt.skip>
177176
<codehaus.jackson.version>1.9.13</codehaus.jackson.version>
@@ -3350,8 +3349,7 @@
33503349
<artifactId>mvn-scalafmt_${scala.binary.version}</artifactId>
33513350
<version>1.0.4</version>
33523351
<configuration>
3353-
<parameters>${scalafmt.parameters}</parameters> <!-- (Optional) Additional command line arguments -->
3354-
<skip>${scalafmt.skip}</skip> <!-- (Optional) skip formatting -->
3352+
<validateOnly>${scalafmt.skip}</validateOnly> <!-- (Optional) skip formatting -->
33553353
<skipSources>${scalafmt.skip}</skipSources>
33563354
<skipTestSources>${scalafmt.skip}</skipTestSources>
33573355
<configLocation>dev/.scalafmt.conf</configLocation> <!-- (Optional) config location -->

0 commit comments

Comments
 (0)