Skip to content

Commit eeef0e7

Browse files
srowendongjoon-hyun
authored andcommitted
[SPARK-29578][TESTS][2.4] Add "8634" as another skipped day for Kwajalein timzeone due to more recent timezone updates in later JDK 8
(Backport of #26236) ### What changes were proposed in this pull request? Recent timezone definition changes in very new JDK 8 (and beyond) releases cause test failures. The below was observed on JDK 1.8.0_232. As before, the easy fix is to allow for these inconsequential variations in test results due to differing definition of timezones. ### Why are the changes needed? Keeps test passing on the latest JDK releases. ### Does this PR introduce any user-facing change? None ### How was this patch tested? Existing tests Closes #27386 from srowen/SPARK-29578.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent b93f250 commit eeef0e7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,12 +677,12 @@ class DateTimeUtilsSuite extends SparkFunSuite {
677677

678678
// There are some days are skipped entirely in some timezone, skip them here.
679679
val skipped_days = Map[String, Set[Int]](
680-
"Kwajalein" -> Set(8632, 8633),
680+
"Kwajalein" -> Set(8632, 8633, 8634),
681681
"Pacific/Apia" -> Set(15338),
682682
"Pacific/Enderbury" -> Set(9130, 9131),
683683
"Pacific/Fakaofo" -> Set(15338),
684684
"Pacific/Kiritimati" -> Set(9130, 9131),
685-
"Pacific/Kwajalein" -> Set(8632, 8633),
685+
"Pacific/Kwajalein" -> Set(8632, 8633, 8634),
686686
"MIT" -> Set(15338))
687687
for (tz <- DateTimeTestUtils.ALL_TIMEZONES) {
688688
val skipped = skipped_days.getOrElse(tz.getID, Set.empty)

0 commit comments

Comments
 (0)