Skip to content

Commit f7af9ab

Browse files
HyukjinKwonsarutak
authored andcommitted
[SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
### What changes were proposed in this pull request? This PR is a followup of #32436 which broke JavaScript linter. There was a logical conflict - the linter was added after the last successful test run in that PR. ``` added 118 packages in 1.482s /__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js 34:41 error 'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars 34:47 error 'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars 35:1 error Expected indentation of 2 spaces but found 4 indent 36:1 error Expected indentation of 4 spaces but found 7 indent 37:1 error Expected indentation of 2 spaces but found 4 indent 38:1 error Expected indentation of 4 spaces but found 7 indent 39:1 error Expected indentation of 2 spaces but found 4 indent 556:1 error Expected indentation of 14 spaces but found 16 indent 557:1 error Expected indentation of 14 spaces but found 16 indent ``` ### Why are the changes needed? To recover the build ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested: ```bash ./dev/lint-js lint-js checks passed. ``` Closes #32541 from HyukjinKwon/SPARK-34764-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
1 parent b6a0a7e commit f7af9ab

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

core/src/main/resources/org/apache/spark/ui/static/executorspage.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ function getThreadDumpEnabled() {
3131
return threadDumpEnabled;
3232
}
3333

34-
function formatLossReason(removeReason, type, row) {
35-
if (removeReason) {
36-
return removeReason
37-
} else {
38-
return ""
39-
}
34+
function formatLossReason(removeReason) {
35+
if (removeReason) {
36+
return removeReason
37+
} else {
38+
return ""
39+
}
4040
}
4141

4242
function formatStatus(status, type, row) {
@@ -553,8 +553,8 @@ $(document).ready(function () {
553553
}
554554
},
555555
{
556-
data: 'removeReason',
557-
render: formatLossReason
556+
data: 'removeReason',
557+
render: formatLossReason
558558
}
559559
],
560560
"order": [[0, "asc"]],

0 commit comments

Comments
 (0)