From 8746150bf2223622926d671c9c2005c37d18c036 Mon Sep 17 00:00:00 2001 From: Pavithra Ramachandran Date: Thu, 24 Oct 2019 11:14:31 +0200 Subject: [PATCH 1/3] [SPARK-29504][WEBUI] Toggle full job description on click On clicking job description in jobs page, the description was not shown fully. Add the function for the click event on description. when there is a long description of a job, it cannot be seen fully in the UI. The feature was added in https://github.com/apache/spark/pull/24145 But it is missed after https://github.com/apache/spark/pull/25374 Before change: ![Screenshot from 2019-10-23 11-23-00](https://user-images.githubusercontent.com/51401130/67361914-827b0080-f587-11e9-9181-d49a6a836046.png) After change: on Double click over decription ![Screenshot from 2019-10-23 11-20-02](https://user-images.githubusercontent.com/51401130/67361936-932b7680-f587-11e9-9e59-d290abed4b70.png) No Manually test Closes #26222 from PavithraRamachandran/jobs_description_tooltip. Authored-by: Pavithra Ramachandran Signed-off-by: Gengliang Wang From 14de92fae0691cdd407ee0653271cf8a7a863334 Mon Sep 17 00:00:00 2001 From: Pavithra Ramachandran Date: Thu, 31 Oct 2019 10:45:07 +0530 Subject: [PATCH 2/3] job description toggle --- core/src/main/resources/org/apache/spark/ui/static/webui.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.js b/core/src/main/resources/org/apache/spark/ui/static/webui.js index f01c567ba58a..47f8651ca1dd 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/webui.js +++ b/core/src/main/resources/org/apache/spark/ui/static/webui.js @@ -83,4 +83,10 @@ $(function() { collapseTablePageLoad('collapse-aggregated-rdds','aggregated-rdds'); collapseTablePageLoad('collapse-aggregated-activeBatches','aggregated-activeBatches'); collapseTablePageLoad('collapse-aggregated-completedBatches','aggregated-completedBatches'); +}); +$(function() { + // Show/hide full job description on click event. + $(".description-input").click(function() { + $(this).toggleClass("description-input-full"); + }); }); \ No newline at end of file From edbfd6061aa8c5966bbf6c73c878730edd9747de Mon Sep 17 00:00:00 2001 From: Pavithra Ramachandran Date: Sat, 2 Nov 2019 07:34:44 +0530 Subject: [PATCH 3/3] review comment --- core/src/main/resources/org/apache/spark/ui/static/webui.js | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.js b/core/src/main/resources/org/apache/spark/ui/static/webui.js index 47f8651ca1dd..76570d5e7b80 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/webui.js +++ b/core/src/main/resources/org/apache/spark/ui/static/webui.js @@ -84,6 +84,7 @@ $(function() { collapseTablePageLoad('collapse-aggregated-activeBatches','aggregated-activeBatches'); collapseTablePageLoad('collapse-aggregated-completedBatches','aggregated-completedBatches'); }); + $(function() { // Show/hide full job description on click event. $(".description-input").click(function() {