diff --git a/common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala b/common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala index f90eb4a77071..6367da550265 100644 --- a/common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala +++ b/common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala @@ -193,6 +193,7 @@ private[spark] object LogKeys { case object DELAY extends LogKey case object DELEGATE extends LogKey case object DELTA extends LogKey + case object DEPENDENCY extends LogKey case object DEPRECATED_KEY extends LogKey case object DERIVATIVE extends LogKey case object DESCRIPTION extends LogKey @@ -279,6 +280,7 @@ private[spark] object LogKeys { case object FINAL_OUTPUT_PATH extends LogKey case object FINAL_PATH extends LogKey case object FINISH_TRIGGER_DURATION extends LogKey + case object FORMATTED_CODE extends LogKey case object FREE_MEMORY_SIZE extends LogKey case object FROM_OFFSET extends LogKey case object FROM_TIME extends LogKey diff --git a/common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala b/common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala index ae00987cd69f..ff622dbd4096 100644 --- a/common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala +++ b/common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala @@ -36,7 +36,7 @@ import org.apache.ivy.plugins.repository.file.FileRepository import org.apache.ivy.plugins.resolver.{ChainResolver, FileSystemResolver, IBiblioResolver} import org.apache.spark.SparkException -import org.apache.spark.internal.Logging +import org.apache.spark.internal.{Logging, LogKeys, MDC} import org.apache.spark.util.ArrayImplicits._ /** Provides utility functions to be used inside SparkSubmit. */ @@ -215,7 +215,8 @@ private[spark] object MavenUtils extends Logging { if (artifactInfo.getExt == "jar") { true } else { - logInfo(s"Skipping non-jar dependency ${artifactInfo.getId}") + logInfo(log"Skipping non-jar dependency ${MDC(LogKeys.DEPENDENCY, + artifactInfo.getId)}") false } } @@ -515,8 +516,9 @@ private[spark] object MavenUtils extends Logging { val failedReports = rr.getArtifactsReports(DownloadStatus.FAILED, true) if (failedReports.nonEmpty && noCacheIvySettings.isDefined) { val failedArtifacts = failedReports.map(r => r.getArtifact) - logInfo(s"Download failed: ${failedArtifacts.mkString("[", ", ", "]")}, " + - s"attempt to retry while skipping local-m2-cache.") + logInfo(log"Download failed: ${MDC(LogKeys.MESSAGE, + failedArtifacts.mkString("[", ", ", "]"))}, " + + log"attempt to retry while skipping local-m2-cache.") failedArtifacts.foreach(artifact => { clearInvalidIvyCacheFiles(artifact.getModuleRevisionId, ivySettings.getDefaultCache) }) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala index a39c10866984..d2932f83d914 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala @@ -1561,9 +1561,9 @@ object CodeGenerator extends Logging { private def logGeneratedCode(code: CodeAndComment): Unit = { val maxLines = SQLConf.get.loggingMaxLinesForCodegen if (Utils.isTesting) { - logError(s"\n${CodeFormatter.format(code, maxLines)}") + logError(log"\n${MDC(LogKeys.FORMATTED_CODE, CodeFormatter.format(code, maxLines))}") } else { - logInfo(s"\n${CodeFormatter.format(code, maxLines)}") + logInfo(log"\n${MDC(LogKeys.FORMATTED_CODE, CodeFormatter.format(code, maxLines))}") } }