[SPARK-11802][SQL] Kryo-based encoder for opaque types in Datasets #9789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * (Scala-specific) Creates an encoder that serializes objects of type T using Kryo. | ||
| * This encoder maps T into a single byte array (binary) field. | ||
| */ | ||
| def kryo[T: ClassTag]: Encoder[T] = { |
Contributor
There was a problem hiding this comment.
How about putting this method into ExpressionEncoder? I think Encoders is only used at java side as the lack of implicit magic.
Contributor
There was a problem hiding this comment.
then we can change the return type to ExpressionEncoder[T] and make the tests less verbose with asInstanseOf
Contributor
Author
There was a problem hiding this comment.
what if we want to use kryo in scala?
Contributor
There was a problem hiding this comment.
oh, this can't be done by implicit, I was wrong, nvm.
|
Test build #46146 has finished for PR 9789 at commit
|
|
Test build #46179 has finished for PR 9789 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
I also found a bug with self-joins returning incorrect results in the Dataset API. Two test cases attached and filed SPARK-11803. Author: Reynold Xin <rxin@databricks.com> Closes #9789 from rxin/SPARK-11802. (cherry picked from commit 5e2b444) Signed-off-by: Reynold Xin <rxin@databricks.com>
|
Test build #46175 has finished for PR 9789 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also found a bug with self-joins returning incorrect results in the Dataset API. Two test cases attached and filed SPARK-11803.