More sensible default language pair

[MaathavanJkr]

more sensible default language pair when apertium.org is loaded. I think it might work!

[sushain97]

Hi! Thanks for the PR.

No new JS should go into index.html.in. It should all go in assets/js.

[MaathavanJkr]

@sushain97 how can i run this code?

[sushain97]

What error did you run into when following the instructions in the README?

[MaathavanJkr]

I ran it. :), But

[sushain97]

But...?

[MaathavanJkr]

okay im done i think. :)

[MaathavanJkr]

Now the default translator pair is first available user's browser preference language pair. :) or it will select english as default. :)

[MaathavanJkr]

https://maathavanjkr.github.io/ here you can see it in action. :)

[MaathavanJkr]

#343

[sushain97]

Thanks for moving this code!

[jonorthwash]

This appears to change to the browser-preferred language even if it isn't an available for translation. This is incorrect behaviour.

[MaathavanJkr]

This appears to change to the browser-preferred language even if it isn't an available for translation. This is incorrect behaviour.

Its Done I think. :) anymore changes? :)

[sushain97]

Looking better! Still some concerns and broken tests apparently.

[sushain97]

I'm fine with

curSrcLang = iso639CodesInverse[lang];
autoSelectDstLang();

Just not happy with checking whether things exist in local storage first. If things do exist there, we should let restoreChoices('translator') which runs after us restore them and overwrite our changes. Does that not work?

[MaathavanJkr]

I'm fine with

curSrcLang = iso639CodesInverse[lang];
autoSelectDstLang();

Just not checking whether things exist in local storage first. If things do exist there, we should let restoreChoices('translator') which runs after us restore them and overwrite our changes. Does that not work?

I think it will work. Lets try. :)

[MaathavanJkr]

@sushain97 its working on both Chrome and IE. Can u please take a look at the code. :)

[sushain97]

I'm not exactly sure we're on the same page. I suggested leaving this as is with your new code setting curSrcLang, etc. Then, restoreChoices('translator'); would run after setDefaultSrcLang() (as it already does), overwriting your settings.

[MaathavanJkr]

I'm not exactly sure we're on the same page. I suggested leaving this as is with your new code setting curSrcLang, etc. Then, restoreChoices('translator'); would run after setDefaultSrcLang() (as it already does), overwriting your settings.

But it didnt work when running it after setDefaultSrcLang() function

[sushain97]

Why?

[MaathavanJkr]

Im not sure with it, wait i will have look.

[MaathavanJkr]

Got it! Because restoreChoices('translator'); function doesnot set curSrcLang but changes the UI. So someanother function after it changes the UI with curSrcLang.

[sushain97]

apertium-html-tools/assets/js/persistence.js

Line 158 in 0fe0c81

setCurSrcLang(storedCurSrcLang);

doesn't this do it?

[MaathavanJkr]

apertium-html-tools/assets/js/persistence.js

Line 158 in 0fe0c81

setCurSrcLang(storedCurSrcLang);

doesn't this do it?

yeah, You are right.

I ran some tests and It seems the language we set to curSrcLang is set to Stored Lang when running function autoSelectDstLang();. then when we run restoreChoices('translator') its sets the same language. But i cant find where do that happens. Im trying...

[MaathavanJkr]

Gotcha! In function autoSelectDstLang();, the function handleNewCurrentLang() is called. there the function persistChoices() is called which updates both curSrcLang and curDstLang to the local storage.
If its right we can simple solve it by calling handleNewCurrentLang() after restoreChoices('translator').

[sushain97]

Ah, jeez. Good detective work. I made some tweaks that I think should fix it?

Also, I wonder if we should be calling handleNewCurrentLang directly...

[MaathavanJkr]

Ah, jeez. Good detective work. I made some tweaks that I think should fix it?

Also, I wonder if we should be calling handleNewCurrentLang...

Yeah!! I thought this to do inside set setDefaultLang();, But this one is better. Thanks! :)

[MaathavanJkr]

Ah, jeez. Good detective work. I made some tweaks that I think should fix it?

Also, I wonder if we should be calling handleNewCurrentLang directly...

And i think we should call handleNewCurrentLang for curSrcLang under setDefaultLang(). as when im testing, the UI isnt set when we ran for first visit.

[sushain97]

And i think we should call handleNewCurrentLang for curSrcLang under setDefaultLang(). as when im testing, the UI isnt set when we ran for first visit.

Yep, that sounds like the right move after taking a quick look at the code. Could you make that tweak and test it?

[MaathavanJkr]

Yep, that sounds like the right move after taking a quick look at the code. Could you make that tweak and test it?

Done. :), Tested on both Chrome and IE for both instances and its working perfectly.

[sushain97]

Seems good!

[sushain97]

@jonorthwash This looks good on my end. Wanna try it before I merge? I don't have any particularly unique browser settings.