Skip to content

Conversation

@diogoscf
Copy link
Contributor

Fixes #333

What was happening was that the available width was being calculated assuming that the source buttons were on the left and the target buttons were on the right, which is only the case if the language is ltr, so the code thought that there was much less space than there really was.

@diogoscf
Copy link
Contributor Author

Umm... I don't understand what circleci is complaining about now...

Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@sushain97
Copy link
Member

What was happening was that the available width was being calculated assuming that the source buttons were on the left and the target buttons were on the right, which is only the case if the language is ltr, so the code thought that there was much less space than there really was.

Ahhhh, right. Good catch. Probably my fault.

@sushain97
Copy link
Member

BTW, I suggest yarn installing locally and running Flow/ESLint through your IDE.

@diogoscf diogoscf requested a review from sushain97 December 10, 2019 18:58
@jonorthwash jonorthwash self-requested a review December 11, 2019 01:58
jonorthwash
jonorthwash previously approved these changes Dec 11, 2019
sushain97
sushain97 previously approved these changes Dec 11, 2019
Copy link
Member

@sushain97 sushain97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. @jonorthwash, I'm guessing you've tested this?

@jonorthwash
Copy link
Member

Code LGTM. @jonorthwash, I'm guessing you've tested this?

Yep, it looks really nice (i.e., the way it's supposed to) :D

@sushain97 sushain97 dismissed stale reviews from jonorthwash and themself via d8ac886 December 12, 2019 06:56
sushain97
sushain97 previously approved these changes Dec 12, 2019
@sushain97
Copy link
Member

sorry for the extra commits, trying to get dockerhub to build commits again and it seems to have worked!

@sushain97 sushain97 merged commit 81b465f into apertium:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language dropdowns bug in RTL locales

3 participants