-
Notifications
You must be signed in to change notification settings - Fork 94
Fixed dropdowns in RTL mode #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Umm... I don't understand what circleci is complaining about now... |
sushain97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Ahhhh, right. Good catch. Probably my fault. |
|
BTW, I suggest |
sushain97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. @jonorthwash, I'm guessing you've tested this?
Yep, it looks really nice (i.e., the way it's supposed to) :D |
|
sorry for the extra commits, trying to get dockerhub to build commits again and it seems to have worked! |
Fixes #333
What was happening was that the available width was being calculated assuming that the source buttons were on the left and the target buttons were on the right, which is only the case if the language is ltr, so the code thought that there was much less space than there really was.