Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-async-dns-resolver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.1
Choose a base ref
...
head repository: apple/swift-async-dns-resolver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.2
Choose a head ref
  • 1 commit
  • 5 files changed
  • 2 contributors

Commits on Jan 9, 2024

  1. Fix bug in DNSSD IPv6 address string conversion. (#14) 

    * Fix bug in DNSSD IPv6 address string conversion.

The old implementation converted each byte to a hexadecimal number
separately, meaning that leading zeros in a byte would be dropped
even in the middle of a group.

For example, the address 2620:149:110b:470e:0:0:0:e1a was incorrectly
rendered as              2620:149:11b:47e:0:0:0:e1a, with zeros dropped
in the 3rd and 4th octets.

I figured the most robust fix would be to use inet_ntop to format the
address, which produces a correctly abbreviated address like
2620:149:110b:470e::e1a. This is the approach used in DNSResolver_c-ares.swift.

* Throw error when too-short address is returned

* Fix formatting issues

* Print an error in soundness.sh if swiftformat is not installed

---------

Co-authored-by: Torin Rudeen <[email protected]>
    @torinmr
    torinmr and Torin Rudeen authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    95fda89 View commit details
    Browse the repository at this point in the history
Loading