Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-async-dns-resolver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.4
Choose a base ref
...
head repository: apple/swift-async-dns-resolver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.2.0
Choose a head ref
  • 3 commits
  • 11 files changed
  • 2 contributors

Commits on Feb 13, 2024

  1. Remove NIO dependency (#20)

    Motivation:
    
    NIO's ByteBuffer is used as an implementation detail for parsing
    responses in the DNSD implementation. However NIO is quite a heavy
    dependency so we should avoid it if possible.
    
    Modifications:
    
    - Use `ArraySlice<UInt8>` instead of `ByteBuffer` and remove the
      dependency on SwiftNIO
    
    Result:
    
    No dependency on SwiftNIO
    glbrntt authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e8f3efc View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Move platform availability to types (#22)

    Motivation:
    Having `platforms` in `Package.swift` might prevent others from adopting this library.
    
    Modifications:
    - Move platform availability to types
    - Remove `platforms` in `Package.swift`
    - macOS 10.15 seems to be sufficient, so lowering it from v13.0
    yim-lee authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    62fbedd View commit details
    Browse the repository at this point in the history
  2. Add concrete IPv4 and IPv6 types (#21)

    Motivation:
    
    The `ARecord` and `AAAARecord` use the `IPAddress` `enum` as their
    address types. However, they should only use IPv4 and IPv6 addresses
    respectively.
    
    Modifications:
    
    - Add `IPAddress.IPv4` and IPAddress.IPv6` types and use them as the
      associated values in the `IPAddress` enum
    - Change the casing of the `IPAddress` cases from `.IPv4` and `.IPv6` to
      `.ipv4` and `.ipv6` as Swift case names are usually lower-camel case
    
    Result:
    
    - The types of IP address used by `ARecord` and `AAAARecord` are clearer
    glbrntt authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    96a18c6 View commit details
    Browse the repository at this point in the history
Loading