Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.5
Choose a base ref
...
head repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.3.6
Choose a head ref
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on Oct 30, 2023

  1. Disable warnings-as-errors for nightlies (#67) 

    Disable warnings-as-errors for nightlies

### Motivation

Same as apple/swift-openapi-generator#353 but for the runtime package.

### Modifications

Disable warnings as errors on CI for nightlies.

### Result

_[After your change, what will change.]_

### Test Plan

CI should pass again.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.10) - Build finished. 
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (api breakage) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#67
    @czechboy0
    czechboy0 authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    91b16be View commit details
    Browse the repository at this point in the history

  2. [Runtime] Improved content type matching (#65) 

    [Runtime] Improved content type matching

### Motivation

The runtime changes for apple/swift-openapi-generator#315.

### Modifications

- Introduces a new SPI method `Converter.bestContentType` that takes a received content type value and from a provided list of other content types, picks the most appropriate one. This actually follows the specification now, by going from most specific (including parameter matching) to least specific (most wildcard-y).
- Deprecates the previously used methods `Converter.makeUnexpectedContentTypeError` and `Converter.isMatchingContentType`.

### Result

SPI methods that the generated code can use to correctly match content types.

### Test Plan

Added unit tests.


Reviewed by: gjcairo

Builds:
     ✔︎ pull request validation (5.10) - Build finished. 
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (api breakage) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#65
    @czechboy0
    czechboy0 authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    333d73a View commit details
    Browse the repository at this point in the history

  3. [Runtime] Include partial errors in oneOf/anyOf decoding errors (#66) 

    [Runtime] Include partial errors in oneOf/anyOf decoding errors

### Motivation

The runtime changes to address apple/swift-openapi-generator#275.

This makes debugging of decoding of oneOf/anyOf much easier, as the individual errors aren't dropped on the floor anymore.

### Modifications

Added SPI that allows the generated code to collect and report partial errors when a oneOf/anyOf fails to decode (that includes trying multiple subschemas, which themselves emit errors when they're not the right match).

### Result

Easier debugging of oneOf/anyOf decoding issues.

### Test Plan

Tested manually as part of the generator changes, we don't generally test exact error strings.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.10) - Build finished. 
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (docc test) - Build finished. 
     ✔︎ pull request validation (integration test) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 
     ✖︎ pull request validation (api breakage) - Build finished. 

#66
    @czechboy0
    czechboy0 authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a51b3bd View commit details
    Browse the repository at this point in the history
Loading