Skip to content

[DRAFT] ProcessID, Signal, SignalSet, TaskInfo, ResourceUsageInfo #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

[DRAFT] ProcessID, Signal, SignalSet, TaskInfo, ResourceUsageInfo #20

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ad80d0f
WIP: PID, and resource / task info
milseman Feb 5, 2021
0ebaa29
Signal and SignalSet
milseman Feb 5, 2021
544fc8a
TaskInfo and ResourceUsageInfo struct queries
milseman Feb 5, 2021
881a8ad
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
0c32e4e
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
c96a3e6
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
a051d71
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
153e5d3
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
e8b5ab4
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
9edaf16
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
5bc82a4
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
9830717
Update Sources/System/Process/Signal.swift
milseman Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Sources/System/Process/Signal.swift 
Co-authored-by: Karoy Lorentey <[email protected]>
  • Loading branch information
@milseman @lorentey
milseman and lorentey authored Feb 25, 2021
commit a051d71ae486b90c203c78a86d96b233fc827076
2 changes: 1 addition & 1 deletion Sources/System/Process/Signal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ extension Signal {
public static var segmentationViolation: Signal { Signal(SIGSEGV) }

/// SIGSYS (12): non-existent system call invoked (default behavior: create core image)
public static var badSyscall: Signal { Signal(SIGSYS) }
public static var unknownSystemCall: Signal { Signal(SIGSYS) }

/// SIGPIPE (13): write on a pipe with no reader (default behavior: terminate process)
public static var pipe: Signal { Signal(SIGPIPE) }
Copy link
Member

@lorentey lorentey Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static var pipe: Signal { Signal(SIGPIPE) }
public static var brokenPipe: Signal { Signal(SIGPIPE) }

Copy link
Member

@weissi weissi Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, you can also get them on sockets...

Copy link
Member

@lorentey lorentey Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's interesting. 🤔

Broken pipe is what psignal prints on SIGPIPE, which is why I suggested it. It has the advantage that it evokes the original name but also tries to clarify it a little.

Should we use that, use pipe, or should we try to find a more exact term?

Copy link
Member

@lorentey lorentey Feb 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we imported EPIPE as Errno.brokenPipe. I think we should probably use the same name here -- especially since it looks like the error is returned in the exact same situations as when the signal is sent.

[EPIPE]
Broken pipe. A write was attempted on a socket, pipe, or FIFO for which there is no process to read the data.

Expand Down