Skip to content

Tests: explicitly construct FilePath #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tests: explicitly construct FilePath #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Tests: explicitly construct FilePath 
The literal value needs to be converted on different platform.
Explicitly construct the type rather than trying to change the literal
to the platform character type.
  • Loading branch information
@compnerd
compnerd committed Jun 12, 2022
commit 42f999079a3397430493fa4444db84c95c889ca2
2 changes: 1 addition & 1 deletion Tests/SystemTests/FileOperationsTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ final class FileOperationsTest: XCTestCase {

#if !os(Windows)
func testResizeFile() throws {
let fd = try FileDescriptor.open("/tmp/\(UUID().uuidString).txt", .readWrite, options: [.create, .truncate], permissions: .ownerReadWrite)
let fd = try FileDescriptor.open(FilePath("/tmp/\(UUID().uuidString).txt"), .readWrite, options: [.create, .truncate], permissions: .ownerReadWrite)
Copy link
Member

@lorentey lorentey Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. This feels like it indicates an API bug.

Copy link
Contributor

@milseman milseman Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string-taking version should either be disfavored or updated to construct a file path.

try fd.closeAfter {
// File should be empty initially.
XCTAssertEqual(try fd.fileSize(), 0)
Expand Down