Skip to content

Commit 3516e67

Browse files
committed
Documentation
1 parent 1fa587d commit 3516e67

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

.github/issue_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* [ ] Arduino ATmega32U4 board (Leonardo)
55
* [ ] Arduino SAM board (Due)
66
* [ ] Arduino SAMD board (Zero, MKR*)
7-
* [ ] ESP32 board
7+
* [ ] ESP32 board - first check https://github.com/crankyoldgit/IRremoteESP8266
88
* [ ] Teensy board
99
* [ ] Other - please specify
1010

examples/IRrecord/IRrecord.ino

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,13 @@ void storeCode() {
9494
Serial.println("repeat; ignoring.");
9595
return;
9696
}
97+
} else if (codeType == NEC_STANDARD) {
98+
Serial.print("Received NEC: ");
99+
if (irrecv.results.value == REPEAT) {
100+
// Don't record a NEC repeat value as that's useless.
101+
Serial.println("repeat; ignoring.");
102+
return;
103+
}
97104
} else if (codeType == SONY) {
98105
Serial.print("Received SONY: ");
99106
} else if (codeType == SAMSUNG) {

library.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version=2.6.1
33
author=shirriff, z3t0 <[email protected]>
44
maintainer=Armin Joachimsmeyer <[email protected]>
55
sentence=Send and receive infrared signals with multiple protocols
6-
paragraph=Currently included protocols: Aiwa, BoseWave, Denon, Dish, JVC, Lego, LG, MagiQuest, Mitsubishi, Panasonic, RC5, RC6, Samsung, Sanyo, Sharp, Sony, Whynter, (Pronto).<br/><br/><b>New:</b>ESP32 bug fixed, corrected Samsung timing, NEC repeat implementation.<br/>
6+
paragraph=Currently included protocols: Aiwa, BoseWave, Denon, Dish, JVC, Lego, LG, MagiQuest, Mitsubishi, Panasonic, RC5, RC6, Samsung, Sanyo, Sharp, Sony, Whynter, (Pronto).<br/><br/><b>New: </b>ESP32 bug fixed, corrected Samsung timing, NEC repeat implementation.<br/>
77
category=Communication
88
url=https://github.com/z3t0/Arduino-IRremote
99
architectures=*

src/private/IRremoteBoardDefs.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -876,13 +876,10 @@ static void timerConfigForReceive() {
876876
// ESP32 has it own timer API and does not use these macros, but to avoid ifdef'ing
877877
// them out in the common code, they are defined to no-op. This allows the code to compile
878878
// (which it wouldn't otherwise) but irsend will not work until ESP32 specific code is written
879-
// for that -- merlin
880-
// As a warning, sending timing specific code from an ESP32 can be challenging if you need 100%
881-
// reliability because the arduino code may be interrupted and cause your sent waveform to be the
882-
// wrong length. This is specifically an issue for neopixels which require 800Khz resolution.
883-
// IR may just work as is with the common code since it's lower frequency, but if not, the other
884-
// way to do this on ESP32 is using the RMT built in driver like in this incomplete library below
885-
// https://github.com/ExploreEmbedded/ESP32_RMT
879+
//
880+
// The timer code is in the esp32.cpp file
881+
//
882+
// An IRremote version for ESP8266 and ESP32 is available at https://github.com/crankyoldgit/IRremoteESP8266
886883
#elif defined(IR_USE_TIMER_ESP32)
887884

888885
#if ! defined(IR_SEND_PIN)

0 commit comments

Comments
 (0)