improved import library: complains if invalid zip or folders are selected

Author: ffissore

app/src/processing/app/Base.java

@@ -2382,16 +2382,47 @@ public void handleAddLibrary(Editor editor) {
 
     Dimension preferredSize = fileChooser.getPreferredSize();
     fileChooser.setPreferredSize(new Dimension(preferredSize.width + 200, preferredSize.height + 200));
-    
+
     int returnVal = fileChooser.showOpenDialog(editor);
 
     if (returnVal != JFileChooser.APPROVE_OPTION) {
       return;
     }
 
     File sourceFile = fileChooser.getSelectedFile();
+    File tmpFolder = null;
+
+    try {
+      // unpack ZIP
+      if (!sourceFile.isDirectory()) {
+        try {
+          tmpFolder = FileUtils.createTempFolder();
+          ZipDeflater zipDeflater = new ZipDeflater(sourceFile, tmpFolder);
+          zipDeflater.deflate();
+          File[] foldersInTmpFolder = tmpFolder.listFiles(new OnlyDirs());
+          if (foldersInTmpFolder.length != 1) {
+            throw new IOException("Zip doesn't contain one library");
+          }
+          sourceFile = foldersInTmpFolder[0];
+        } catch (IOException e) {
+          editor.statusError(e);
+          return;
+        }
+      }
+
+      // is there a library?
+      File libFolder = scanFatLibrary(sourceFile);
+      if (libFolder == null) {
+        editor.statusError("Not a valid library");
+        return;
+      }
+      String[] headerFiles = headerListFromIncludePath(libFolder);
+      if (headerFiles == null || headerFiles.length == 0) {
+        editor.statusError("Not a valid library");
+        return;
+      }
 
-    if (sourceFile.isDirectory()) {
+      // copy folder
       File destinationFolder = new File(getSketchbookLibrariesFolder(), sourceFile.getName());
       if (!destinationFolder.mkdir()) {
         editor.statusError("Can't create folder: " + sourceFile.getName() + " into libraries folder");
@@ -2403,15 +2434,10 @@ public void handleAddLibrary(Editor editor) {
         editor.statusError(e);
         return;
       }
-    } else {
-      try {
-        ZipDeflater zipDeflater = new ZipDeflater(sourceFile, getSketchbookLibrariesFolder());
-        zipDeflater.deflate();
-      } catch (IOException e) {
-        editor.statusError(e);
-        return;
-      }
+      editor.statusNotice(_("Library added to your libraries. Check \"Import library\" menu"));
+    } finally {
+      // delete zip created temp folder, if exists
+      FileUtils.recursiveDelete(tmpFolder);
     }
-    editor.statusNotice(_("Library added to your libraries. Check \"Import library\" menu"));
   }
 }

app/src/processing/app/helpers/FileUtils.java

@@ -4,6 +4,7 @@
 import java.io.FileInputStream;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.util.Random;
 
 public class FileUtils {
 
@@ -66,6 +67,9 @@ public static void copy(File sourceFolder, File destFolder) throws IOException {
   }
 
   public static void recursiveDelete(File file) {
+    if (file == null) {
+      return;
+    }
     if (file.isDirectory()) {
       for (File current : file.listFiles()) {
         if (current.isDirectory()) {
@@ -78,4 +82,12 @@ public static void recursiveDelete(File file) {
     file.delete();
   }
 
+  public static File createTempFolder() throws IOException {
+    File tmpFolder = new File(System.getProperty("java.io.tmpdir"), "arduino_" + new Random().nextInt(1000000));
+    if (!tmpFolder.mkdir()) {
+      throw new IOException("Unable to create temp folder " + tmpFolder);
+    }
+    return tmpFolder;
+  }
+
 }