Interpret "empty" Port object as no-port in upload (#2202)

cmaglie · web-flow · commit 8310d0103e2e · 2023-06-06T14:11:05.000+02:00
diff --git a/commands/upload/upload.go b/commands/upload/upload.go
@@ -195,7 +195,7 @@ func runProgramAction(pme *packagemanager.Explorer,
 	if burnBootloader && programmerID == "" {
 		return &arduino.MissingProgrammerError{}
 	}
-	if port == nil {
+	if port == nil || (port.Address == "" && port.Protocol == "") {
 		// For no-port uploads use "default" protocol
 		port = &rpc.Port{Protocol: "default"}
 	}

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ func runProgramAction(pme *packagemanager.Explorer,`
`195`	`195`	`if burnBootloader && programmerID == "" {`
`196`	`196`	`return &arduino.MissingProgrammerError{}`
`197`	`197`	`}`
`198`		`- if port == nil {`
	`198`	`+ if port == nil \|\| (port.Address == "" && port.Protocol == "") {`
`199`	`199`	`// For no-port uploads use "default" protocol`
`200`	`200`	`port = &rpc.Port{Protocol: "default"}`
`201`	`201`	`}`