Skip to content

Commit e8aac59

Browse files
committed
Re-optimize names.py to exclude duplicates in single file
1 parent cce7009 commit e8aac59

File tree

1 file changed

+23
-16
lines changed

1 file changed

+23
-16
lines changed

names/names.py

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,38 @@
1212

1313
# 64 duplicates
1414
duplicates = []
15-
for name_1 in names_1:
16-
for name_2 in names_2:
17-
if name_1 == name_2:
18-
duplicates.append(name_1)
15+
# for name_1 in names_1:
16+
# for name_2 in names_2:
17+
# if name_1 == name_2:
18+
# duplicates.append(name_1)
1919

2020
# Truly 124 duplicates total
21-
2221
# create dictionary
23-
unique = {}
22+
# unique = {}
2423

2524
# loop over recording unique names
26-
for i in range(max(len(names_1), len(names_2))):
27-
if names_1[i] == names_2[i]:
28-
unique[names_1[i]] = True
29-
duplicates.append(names_1[i])
25+
# for i in range(max(len(names_1), len(names_2))):
26+
# if names_1[i] == names_2[i]:
27+
# unique_1[names_1[i]] = True
28+
# unique_2[names_2[i]] = True
29+
# duplicates.append(names_1[i])
30+
31+
# # check for duplicate, add to list
32+
# if names_1[i] in unique.keys():
33+
# duplicates.append(names_1[i])
34+
35+
# if names_2[i] in unique.keys():
36+
# duplicates.append(names_2[i])
37+
38+
# unique[names_1[i]] = True
39+
# unique[names_2[i]] = True
3040

31-
# check for duplicate, add to list
32-
if names_1[i] in unique.keys():
33-
duplicates.append(names_1[i])
41+
unique = { i : True for i in names_1 }
3442

43+
for i in range(len(names_2)):
3544
if names_2[i] in unique.keys():
3645
duplicates.append(names_2[i])
37-
38-
unique[names_1[i]] = True
39-
unique[names_2[i]] = True
46+
4047

4148

4249
end_time = time.time()

0 commit comments

Comments
 (0)