Added "Meetup.com" provider #220

dance2die · 2018-02-24T01:49:47Z

Hi, I have added a provider for Meetup.com.

Would you review the content and see if it's mergeable?
Please let me know should the merge does not conform to a guideline or a standard.

Test Steps

Add .AddMeetup in Startup.cs

.AddMeetup(options =>
{
    options.ClientId = "CLIENT ID";
    options.ClientSecret = "CLIENT SECRET";
    options.Scope.Add("basic");
});

The list of Scope values can be found here.

Create a Meetup OAuth consumer from here to get a ClientId (shown as Key) and ClientSecret (shown as Secret)
2.1 and set the Redirect URL to "https://localhost:44318/"

Once you've added the Meetup provider, the test site will display "Connect using Meetup" as shown below

Login to Meetup.com
Redirected page shows claims processed

dance2die · 2018-02-24T02:07:59Z

@PinpointTownes Hi Kevin,

Would you be able to guide me on what I am doing wrong and how I can fix the issue?
(I've left a comment on the build failure on Gitter, just in case)

Thank you.

kinosang · 2018-02-24T02:18:28Z

CI failed because it can't download KoreBuild from GitHub. No idea why it happened.

kinosang · 2018-02-24T02:21:21Z

src/AspNet.Security.OAuth.Meetup/MeetupAuthenticationOptions.cs

+            ClaimActions.MapJsonKey("urn:meetup:localized_country_name", "localized_country_name");
+            ClaimActions.MapJsonKey("urn:meetup:state", "state");
+
+			// Map user's photo information returned as a nested object


keep the indent of 12 spaces.

I am sorry about that.
My Visual Studio has tabs as a space by default. I will update the indentations.

kinosang · 2018-02-24T02:22:10Z

src/AspNet.Security.OAuth.Meetup/MeetupAuthenticationOptions.cs

+            ClaimActions.MapJsonKey(ClaimTypes.Email, "email");
+
+			// Map custom claims
+            ClaimActions.MapJsonKey("urn:meetup:name", "name");


See #216, it introduces ClaimTypes constants for the claims.

OK, let me refer to the #216

…(comment)

…ggested by kinosang on aspnet-contrib#220 (comment)

dance2die · 2018-02-24T03:03:45Z

@kinosang
AppVeyor is still failing while Travis is passing.

According to GitHub issue on AspNet KoreBuild, zip version is not supported any more

kevinchalet · 2018-02-24T12:32:06Z

According to GitHub issue on AspNet KoreBuild, zip version is not supported any more

We'll probably move to the new version at some point, but the error you're seeing on AppVeyor doesn't have anything to do with that: it's caused by the fact the GitHub.com folks removed support for TLS 1.0 and 1.1 2 days ago. The AppVeyor team is working on a global fix to force .NET apps to use TLS 1.2 in all their CI images.

In the meantime, let's just ignore the AppVeyor errors.

dance2die · 2018-02-24T13:03:15Z

Thank you for looking into the AppVeyor issue @PinpointTownes.

…ten to update it)

…(comment)

…ggested by kinosang on aspnet-contrib#220 (comment)

…ten to update it)

dance2die · 2018-02-28T18:19:19Z

I've rebased according to an advice in #224.
Would you review to see if the rebase is done properly? (My first time doing a rebase).
Thank you.

martincostello

This needs re-syncing with the dev branch so as to not include the changes to the build scripts.

martincostello · 2019-05-14T13:24:03Z

src/AspNet.Security.OAuth.Meetup/MeetupClaimTypes.cs

+        public const string PhotoBaseUrl = "urn:meetup:photo.base_url";
+
+        public const string PhotoType = "urn:meetup:photo.type";
+


Nit: remove blank line here.

martincostello · 2019-05-14T13:25:18Z

Thanks for the PR @dance2die - as part of the preparation for ASP.NET Core 3.0 support, tests are being added to help make things easier to maintain and validate going forwards (see #292).

Once tests are merged into the dev branch, could you copy the approach to add tests for the new provider into this PR please?

martincostello · 2019-05-19T14:44:12Z

#280 has been merged to dev now. If you rebase and update any tests as appropriate, we can look at merging this PR soon.

martincostello · 2019-05-28T16:40:07Z

Closing due to inactivity and merge conflicts - please re-open and rebase if you would like to pursue adding a provider for Meetup.com in a future release.

dance2die · 2019-05-28T17:03:21Z

@martincostello
Sorry about the late follow up.

I haven't been using .NET core for awhile and I will leave it to others to do a PR should this is need Meetup provider.

dance2die added 3 commits February 22, 2018 21:45

First working version of Meetup provider

2feeb48

Removed commented-out code and an unused using reference

c3ee580

Mapped all user's claim options

a3447be

Added Meetup provider to the solution

7037b3c

kinosang reviewed Feb 24, 2018

View reviewed changes

dance2die added 3 commits February 23, 2018 21:28

Updated indentation as suggested by "kinosang" on aspnet-contrib#220 …

42e771c

…(comment)

Fixed indentation as suggested by kinosang on aspnet-contrib#220

522fb33

Introduced a ClaimType static constant class "MeetupClaimTypes" as su…

8648b81

…ggested by kinosang on aspnet-contrib#220 (comment)

dance2die and others added 11 commits February 24, 2018 13:34

Updated Meetup package author & company in the package (I have forgot…

f15cb87

…ten to update it)

Migrate to the latest KoreBuild version

1d66b8f

First working version of Meetup provider

cb903be

Removed commented-out code and an unused using reference

eef1c57

Mapped all user's claim options

e8a00a2

Added Meetup provider to the solution

4d32726

Updated indentation as suggested by "kinosang" on aspnet-contrib#220 …

f3a1c26

…(comment)

Fixed indentation as suggested by kinosang on aspnet-contrib#220

8f6c909

Introduced a ClaimType static constant class "MeetupClaimTypes" as su…

79d08a8

…ggested by kinosang on aspnet-contrib#220 (comment)

Updated Meetup package author & company in the package (I have forgot…

7fe7f1b

…ten to update it)

Took remote solution

ddf0259

kevinchalet force-pushed the dev branch from f5a5364 to 84d5005 Compare March 7, 2018 18:04

kevinchalet added enhancement and removed enhancement labels Mar 7, 2018

kevinchalet added this to the 2.1.0 milestone Jun 8, 2018

martincostello reviewed May 14, 2019

View reviewed changes

martincostello removed this from the 2.1.0 milestone May 24, 2019

martincostello added the new provider label May 27, 2019

martincostello closed this May 28, 2019

dance2die deleted the meetup_test_branch branch May 28, 2019 17:03

		public const string PhotoBaseUrl = "urn:meetup:photo.base_url";

		public const string PhotoType = "urn:meetup:photo.type";

Added "Meetup.com" provider #220

Added "Meetup.com" provider #220

Uh oh!

Conversation

dance2die commented Feb 24, 2018

Test Steps

Uh oh!

dance2die commented Feb 24, 2018

Uh oh!

kinosang commented Feb 24, 2018

Uh oh!

kinosang Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

dance2die Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

kinosang Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

dance2die Feb 24, 2018

Choose a reason for hiding this comment

Uh oh!

dance2die commented Feb 24, 2018

Uh oh!

kevinchalet commented Feb 24, 2018

Uh oh!

dance2die commented Feb 24, 2018

Uh oh!

dance2die commented Feb 28, 2018

Uh oh!

martincostello left a comment

Choose a reason for hiding this comment

Uh oh!

martincostello May 14, 2019

Choose a reason for hiding this comment

Uh oh!

martincostello commented May 14, 2019

Uh oh!

martincostello commented May 19, 2019

Uh oh!

martincostello commented May 28, 2019

Uh oh!

dance2die commented May 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants