Dispose of resources

Dispose of HttpRequestMessage and HttpResponseMessage.
Simplify JSON parsing by removing using block.

Author: martincostello

generators/app/templates/AuthenticationHandler.cs

@@ -51,13 +51,13 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
             // TODO Append any additional query string parameters required
             //endpoint = QueryHelpers.AddQueryString(endpoint, "token", tokens.AccessToken);
 
-            var request = new HttpRequestMessage(HttpMethod.Get, endpoint);
+            using var request = new HttpRequestMessage(HttpMethod.Get, endpoint);
             request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
 
             // TODO Add any HTTP request headers required
             //request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", tokens.AccessToken);
 
-            var response = await Backchannel.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, Context.RequestAborted);
+            using var response = await Backchannel.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, Context.RequestAborted);
             if (!response.IsSuccessStatusCode)
             {
                 Logger.LogError("An error occurred while retrieving the user profile: the remote server " +
@@ -69,15 +69,14 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
                 throw new HttpRequestException("An error occurred while retrieving the user profile from <%= name %>.");
             }
 
-            using (var payload = JsonDocument.Parse(await response.Content.ReadAsStringAsync()))
-            {
-                var principal = new ClaimsPrincipal(identity);
-                var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload.RootElement);
-                context.RunClaimActions();
+            using var payload = JsonDocument.Parse(await response.Content.ReadAsStringAsync());
 
-                await Options.Events.CreatingTicket(context);
-                return new AuthenticationTicket(context.Principal, context.Properties, Scheme.Name);
-            }
+            var principal = new ClaimsPrincipal(identity);
+            var context = new OAuthCreatingTicketContext(principal, properties, Context, Scheme, Options, Backchannel, tokens, payload.RootElement);
+            context.RunClaimActions();
+
+            await Options.Events.CreatingTicket(context);
+            return new AuthenticationTicket(context.Principal, context.Properties, Scheme.Name);
         }
     }
 }