Skip to content

Commit cea274a

Browse files
committed
Sanitize usage sample. You can see how this constraints caused by Xamarin.Android package naming policy is stupid.
1 parent 03982b1 commit cea274a

File tree

5 files changed

+2
-7
lines changed

5 files changed

+2
-7
lines changed

Binding/ArchitectureComponentsSample/ArchitectureComponentsSample.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<MonoAndroidResourcePrefix>Resources</MonoAndroidResourcePrefix>
1919
<MonoAndroidAssetsPrefix>Assets</MonoAndroidAssetsPrefix>
2020
<AndroidUseLatestPlatformSdk>false</AndroidUseLatestPlatformSdk>
21+
<AndroidPackageNamingPolicy>Lowercase</AndroidPackageNamingPolicy>
2122
</PropertyGroup>
2223
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
2324
<DebugSymbols>true</DebugSymbols>
@@ -39,8 +40,8 @@
3940
<ErrorReport>prompt</ErrorReport>
4041
<WarningLevel>4</WarningLevel>
4142
<AndroidManagedSymbols>true</AndroidManagedSymbols>
42-
<AndroidUseSharedRuntime>false</AndroidUseSharedRuntime>
4343
<IntermediateOutputPath>obj\Release</IntermediateOutputPath>
44+
<AndroidSupportedAbis>x86</AndroidSupportedAbis>
4445
</PropertyGroup>
4546
<ItemGroup>
4647
<Reference Include="System" />

Binding/ArchitectureComponentsSample/MainActivity.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
namespace ArchitectureComponentsSample
1010
{
1111
[Activity (Label = "ArchitectureComponentsSample", MainLauncher = true)]
12-
// FIXME: this requiring [Register] attribute it really stupid and Xamarin.Android team should immediately stop package name mangling into MD5
13-
// or fix PackageNamingPolicy related bug that it is disregarded at all.
14-
[global::Android.Runtime.Register ("architecturecomponentssample.MainActivity")]
1512
public class MainActivity : LifecycleActivity
1613
{
1714
protected override void OnCreate(Bundle savedInstanceState)
@@ -28,9 +25,6 @@ protected override void OnCreate(Bundle savedInstanceState)
2825

2926
// FIXME: this should not be public. [InternalsVisibleTo] is generated for the extensibility dll
3027
// within this app before build, but it does not seem to work yet.
31-
// FIXME: this requiring [Register] attribute it really stupid and Xamarin.Android team should immediately stop package name mangling into MD5
32-
// or fix PackageNamingPolicy related bug that it is disregarded at all.
33-
[global::Android.Runtime.Register ("architecturecomponentssample.TestObserver")]
3428
public class TestObserver : Java.Lang.Object, ILifecycleObserver
3529
{
3630
[OnLifecycleEvent (OnLifecycleEvent.OnAny)]
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)