fix(UsersRepo): pass $value in auth0_update_meta filter#847
Merged
evansims merged 1 commit intoauth0:masterfrom May 31, 2022
QWp6t:patch-1
Merged
fix(UsersRepo): pass $value in auth0_update_meta filter#847evansims merged 1 commit intoauth0:masterfrom QWp6t:patch-1
$value in auth0_update_meta filter#847evansims merged 1 commit intoauth0:masterfrom
QWp6t:patch-1
Conversation
Contributor
|
Hi @QWp6t 👋 Thanks for your contribution. Give me a big to investigate this and review. (Going to close and reopen the ticket to kick our stalled CircleCI test on this.) |
Contributor
Author
Contributor
evansims
approved these changes
May 31, 2022
Contributor
evansims
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your patience, and of course, your contribution. We'll get a release cut with this change shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The WP_Auth0_UsersRepo class manages WordPress user meta that is stored by Auth0.
The class contains a series of filters that allow developers to short-circuit methods. The idea behind this is that developers can implement their own way of managing user metadata stored by Auth0.
Currently the method for updating metadata does not pass the
$valuethat is being updated. It only passes the key, which makes it impossible to adequately short-circuit.References
Testing
The current test in
TestUserRepoMeta::testUpdateMetaFilterWorksProperlydoes not adequately test this feature and should be updated.This PR does not update the test.
Checklist
master