Skip to content

fix(UsersRepo): pass $value in auth0_update_meta filter#847

Merged
evansims merged 1 commit intoauth0:masterfrom
QWp6t:patch-1
May 31, 2022
Merged

fix(UsersRepo): pass $value in auth0_update_meta filter#847
evansims merged 1 commit intoauth0:masterfrom
QWp6t:patch-1

Conversation

@QWp6t
Copy link
Contributor

@QWp6t QWp6t commented May 22, 2022

Description

The WP_Auth0_UsersRepo class manages WordPress user meta that is stored by Auth0.

The class contains a series of filters that allow developers to short-circuit methods. The idea behind this is that developers can implement their own way of managing user metadata stored by Auth0.

Currently the method for updating metadata does not pass the $value that is being updated. It only passes the key, which makes it impossible to adequately short-circuit.

References

Testing

The current test in TestUserRepoMeta::testUpdateMetaFilterWorksProperly does not adequately test this feature and should be updated.

This PR does not update the test.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
    • I added the proper doc block above the filter, but otherwise none of these filters appear to be documented elsewhere.
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@QWp6t QWp6t requested a review from a team as a code owner May 22, 2022 17:48
@evansims evansims self-assigned this May 23, 2022
@evansims
Copy link
Contributor

Hi @QWp6t 👋 Thanks for your contribution. Give me a big to investigate this and review. (Going to close and reopen the ticket to kick our stalled CircleCI test on this.)

@evansims evansims closed this May 23, 2022
@evansims evansims reopened this May 23, 2022
@QWp6t
Copy link
Contributor Author

QWp6t commented May 24, 2022

image

@evansims
Copy link
Contributor

anchorman-60

Copy link
Contributor

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your patience, and of course, your contribution. We'll get a release cut with this change shortly.

@evansims evansims merged commit 92f5c6e into auth0:master May 31, 2022
@QWp6t QWp6t deleted the patch-1 branch May 31, 2022 17:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants