-
Notifications
You must be signed in to change notification settings - Fork 35
add otel push exporter #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c6cd148
add otel push exporter
mellowagain ca685a6
rename examples to make it more understanding
mellowagain c838781
add must use notice as well functions to customize timeout and period
mellowagain 89d6504
fail compile if no runtime is enabled
mellowagain 7e41d34
update changelog
mellowagain e0a7ab4
add feature flag documentation
mellowagain 957de34
add documentation
mellowagain 9c870dd
re-add the `not` i accidently added
mellowagain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add must use notice as well functions to customize timeout and period
- Loading branch information
commit c8387811a8ec0b0009cdfa2395ff11a809df4a13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
periodis that the same as push interval? If so, then I think we should not use such a low value, not sure what would be a better value 🤔 Maybe something like 30 seconds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im actually thinking maybe we shouldnt set these at all. then otlp exporter would fall back to using the env variables
OTEL_METRIC_EXPORT_TIMEOUTandOTEL_METRIC_EXPORT_INTERVALand if not found fall back to the default value, currently30timeout and60intervalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have done so now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this, using 30 seconds is probably the better default, but also maybe it'll create struggles with the explorer with the build_info metric being looked for only on the last second. Didn't have time to test Brett's fix, maybe that's not an issue anymore