Skip to content

add missing feature flag to opentelemetry_otlp for otel-push-exporter-http #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2023
Merged

add missing feature flag to opentelemetry_otlp for otel-push-exporter-http #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cec9c55
add missing feature flag to opentelemetry_otlp for otel-http-push-exp…
mellowagain Nov 7, 2023
d654f01
update changelog and rustfmt
mellowagain Nov 7, 2023
ea39d4d
pr review
mellowagain Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Add support for tracing-opentelemetry v0.21 (#147)
- Error messages when using `#[autometrics]` together with `#[async_trait]`
has been improved (#149)
- Fixed missing feature flag for `opentelemetry-otlp` when autometrics feature
`otel-push-exporter` is enabled

## [0.6.0](https://github.com/autometrics-dev/autometrics-rs/releases/tag/v0.5.0) - 2023-08-08

Expand Down
3 changes: 2 additions & 1 deletion autometrics/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ otel-push-exporter = [
"opentelemetry_sdk",
"opentelemetry_api",
"opentelemetry-otlp",
"opentelemetry-otlp/tls-roots",
"opentelemetry-otlp/metrics",
"opentelemetry-otlp/tls-roots"
]

otel-push-exporter-http = [
Expand Down
3 changes: 1 addition & 2 deletions autometrics/src/otel_push_exporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
use opentelemetry_api::metrics::MetricsError;
use opentelemetry_otlp::OtlpMetricPipeline;
use opentelemetry_otlp::{ExportConfig, Protocol, WithExportConfig};
use opentelemetry_otlp::{OtlpMetricPipeline, OTEL_EXPORTER_OTLP_TIMEOUT_DEFAULT};
use opentelemetry_sdk::metrics::MeterProvider;
use opentelemetry_sdk::runtime;
use std::ops::Deref;
use std::time::Duration;

Expand Down