Skip to content

fix(core): Removing StackSet for installing Pipeline role in Org Accounts #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Brian969 merged 3 commits into from
Jan 22, 2021
Merged

fix(core): Removing StackSet for installing Pipeline role in Org Accounts #568

Brian969 merged 3 commits into from
Jan 22, 2021

Conversation

@naveenkoppula
Copy link
Contributor

@naveenkoppula naveenkoppula commented Jan 20, 2021 •
edited
Loading

  • Creating CloudFormation stack for creating PipelineRole in Org Accounts by assuming role mentioned in "global-options/organization-admin-role".

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@naveenkoppula naveenkoppula changed the title fix( fix(core): Removing StackSet for installing Pipeline role in Org Accounts Jan 20, 2021
@naveenkoppula naveenkoppula linked an issue Jan 20, 2021 that may be closed by this pull request
[FEATURE] Replace the single StackSet and remove dependence on CloudFormationStackSetExecutionRole #561
Closed
@Brian969
Copy link
Contributor

Brian969 commented Jan 20, 2021

  • This ticket removes the one StackSet from the solution (yeah)
  • It enables using a customized OrgAdminRole name
  • Upgrades require MANUALLY removing the StackSet from the root account (which will remove the stack from the sub-accounts)

archikierstead
archikierstead approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@archikierstead archikierstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@naveenkoppula naveenkoppula marked this pull request as ready for review January 21, 2021 04:26
@Brian969 Brian969 merged commit 6e5fe96 into master Jan 22, 2021
@Brian969 Brian969 deleted the fix/Replace-Stackset branch January 22, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archikierstead archikierstead archikierstead approved these changes

@Brian969 Brian969 Awaiting requested review from Brian969

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Replace the single StackSet and remove dependence on CloudFormationStackSetExecutionRole

3 participants

@naveenkoppula @Brian969 @archikierstead