Skip to content

Handlers can be async #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Handlers can be async #68

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2f7eb74
RuntimeClient::next_event returns a Future
illicitonion Jan 5, 2019
a5072a0
RuntimeClient::event_response returns a Future
illicitonion Jan 5, 2019
4301ffd
RuntimeClient::event_error returns Future
illicitonion Jan 5, 2019
5adedef
Drive execution from a tokio Runtime
illicitonion Jan 5, 2019
695333c
get_next_event uses a future loop_fn
illicitonion Jan 5, 2019
e96a013
Runtime::start is fully async
illicitonion Jan 6, 2019
c65d0e5
Handler returns IntoFuture not Result
illicitonion Jan 6, 2019
2f6e599
Add contrived async Handler example
illicitonion Jan 6, 2019
3aa5a85
Update README
illicitonion Jan 6, 2019
f2ae75f
cargo fmt
illicitonion Jan 6, 2019
0f253c6
cargo fmt with nightly
illicitonion Jan 6, 2019
5d1de6d
Review comments
illicitonion Jan 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cargo fmt with nightly
  • Loading branch information
@illicitonion
illicitonion committed Jan 6, 2019
commit 0f253c6e3036ed7027ba67f2e95a22a5e3362643
3 changes: 1 addition & 2 deletions lambda-runtime-client/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ use hyper::{
};
use serde_derive::Deserialize;
use serde_json;
use tokio::prelude::future::IntoFuture;
use tokio::runtime::TaskExecutor;
use tokio::{prelude::future::IntoFuture, runtime::TaskExecutor};

use crate::error::{ApiError, ErrorResponse, RuntimeApiError};

Expand Down
9 changes: 5 additions & 4 deletions lambda-runtime/src/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,17 @@ use std::{error::Error, marker::PhantomData, result};
use lambda_runtime_client::RuntimeClient;
use serde;
use serde_json;
use tokio::prelude::future::{loop_fn, Future, IntoFuture, Loop};
use tokio::runtime::Runtime as TokioRuntime;
use tokio::{
prelude::future::{loop_fn, Future, IntoFuture, Loop},
runtime::Runtime as TokioRuntime,
};

use crate::{
context::Context,
env::{ConfigProvider, EnvConfigProvider, FunctionSettings},
error::{HandlerError, RuntimeError},
};
use std::sync::Arc;
use std::sync::Mutex;
use std::sync::{Arc, Mutex};
use tokio::runtime::TaskExecutor;

const MAX_RETRIES: i8 = 3;
Expand Down