Consistent examples #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been done automatically (with a few manual adjustments), so there might be some words where upper-case might be useful. This is ignored for now.
This is to resolve conflicts on the feature branch, not on master. (Too lazy for rebase.)
sbeyer
force-pushed
the
consistent-examples
branch
from
b40d09d to
23e35d3
Compare
Since the output of the tests changed, we have a line containing the word "error" in the test output. Since the tests are run within the build_script of AppVeyor, this makes the build process think there was an error and hence fails. Extracting the tests to the test_script should fix the problem.
sbeyer
force-pushed
the
consistent-examples
branch
from
8dc48b7 to
0a26a5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the examples (tests) is inconsistent and confusing.
This branch makes it more consistent and then changes
the output to be a little more appealing.