Skip to content

Commit 62d96d3

Browse files
Re enable bot restriction and add .nojekyll for github pages (ethereum-optimism#1111)
* re-add bot restriction * Update .npmrc to use variable syntax for NPM token and clean up CircleCI config by removing unused environment variables and commands. * add .nojekyll file to prevent Jekyll processing on GitHub Pages * Enhance CircleCI config by adding environment variables to prevent misuse of GitHub tokens and improve security. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent 8e66709 commit 62d96d3

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

.circleci/config.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
machine:
4343
image: ubuntu-2204:2024.08.1
4444
steps:
45+
- continue-if-not-bot
4546
- setup
4647
- run:
4748
name: Prepare git
@@ -72,7 +73,6 @@ jobs:
7273
7374
echo "Committing changes=bot(ci): generate token list"
7475
git commit -m "bot(ci): generate token list"
75-
7676
environment: # this is needed to avoid misuse of the github token and to avoid leaking secrets by mistake with custom commands
7777
NPM_TOKEN: nada
7878
GITHUB_TOKEN_GOVERNANCE: nada
@@ -86,18 +86,13 @@ jobs:
8686
command: |
8787
echo "Pushing changes"
8888
git push "https://x-access-token:${GITHUB_TOKEN_GOVERNANCE}@github.com/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}.git" $CIRCLE_BRANCH
89-
- run:
90-
name: Configure NPM Token and Registry
91-
command: |
92-
npm config set '//registry.npmjs.org/:_authToken' "${NPM_TOKEN}"
9389
- run:
9490
name: Verify NPM Token
9591
command: npm whoami
9692
- run:
9793
name: Publish package
9894
command: pnpm publish
9995

100-
10196
stale:
10297
machine:
10398
image: ubuntu-2204:2024.08.1

.nojekyll

Whitespace-only changes.

.npmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
//registry.npmjs.org/:_authToken=$NPM_TOKEN
1+
//registry.npmjs.org/:_authToken=${NPM_TOKEN}
22
@eth-optimism:registry=https://registry.npmjs.org/
33
always-auth=true

0 commit comments

Comments
 (0)