Reorganization to better reflect libgit2 tests

Rename files for combined types of tests, like tag: read, write
Show group names in DUnit GUI runner
Rename tests to match names, spaces replaced with underscores

Author: jasonpenny

GitForDelphi.dpr

@@ -22,13 +22,11 @@ uses
   uTestsFromLibGit2 in 'TestsFromLibGit2\uTestsFromLibGit2.pas',
   uGitForDelphi in 'uGitForDelphi.pas',
   uTestGitRecords in 'uTestGitRecords.pas',
-  t0402_details in 'TestsFromLibGit2\t0402_details.pas',
-  t0501_walk in 'TestsFromLibGit2\t0501_walk.pas',
+  t04_commit in 'TestsFromLibGit2\t04_commit.pas',
+  t05_revwalk in 'TestsFromLibGit2\t05_revwalk.pas',
   t06_index in 'TestsFromLibGit2\t06_index.pas',
-  t0801_readtag in 'TestsFromLibGit2\t0801_readtag.pas',
-  t0802_write in 'TestsFromLibGit2\t0802_write.pas',
-  t0901_readtree in 'TestsFromLibGit2\t0901_readtree.pas',
-  t0902_modify in 'TestsFromLibGit2\t0902_modify.pas',
+  t08_tag in 'TestsFromLibGit2\t08_tag.pas',
+  t09_tree in 'TestsFromLibGit2\t09_tree.pas',
   uTestHelpers in 'uTestHelpers.pas',
   t10_refs in 'TestsFromLibGit2\t10_refs.pas';
 

TestsFromLibGit2/t0402_details.pas renamed to TestsFromLibGit2/t04_commit.pas

@@ -1,4 +1,4 @@
-unit t0402_details;
+unit t04_commit;
 
 interface
 
@@ -7,15 +7,15 @@ interface
    uTestsFromLibGit2, uGitForDelphi;
 
 type
-   Test0402_details = class(TTestFromLibGit2)
-      procedure query_details_test_0402;
+   Test04_commit_details = class(TTestFromLibGit2)
+      procedure query_the_details_on_a_parsed_commit;
    end;
 
 implementation
 
-{ Test0402_details }
+{ Test04_commit_details }
 
-procedure Test0402_details.query_details_test_0402;
+procedure Test04_commit_details.query_the_details_on_a_parsed_commit;
 const
    commit_ids: array[0..5] of AnsiString = (
       'a4a7dce85cf63874e984719f4fdd239f5145052f', { 0 }
@@ -75,6 +75,6 @@ procedure Test0402_details.query_details_test_0402;
 end;
 
 initialization
-   RegisterTest('From libgit2', Test0402_details.Suite);
+   RegisterTest('From libgit2.t04-commit', Test04_commit_details.NamedSuite('details'));
 
 end.

TestsFromLibGit2/t0501_walk.pas renamed to TestsFromLibGit2/t05_revwalk.pas

@@ -1,4 +1,4 @@
-unit t0501_walk;
+unit t05_revwalk;
 
 interface
 
@@ -7,15 +7,15 @@ interface
    uTestsFromLibGit2, uGitForDelphi;
 
 type
-   Test0501_walk = class(TTestFromLibGit2)
-      procedure simple_walk_test_0501;
+   Test05_revwalk_walk = class(TTestFromLibGit2)
+      procedure do_a_simple_walk_on_a_repo_with_different_sorting_modes;
    end;
 
 implementation
 
-{ Test0501_walk }
+{ Test05_revwalk_walk }
 
-procedure Test0501_walk.simple_walk_test_0501;
+procedure Test05_revwalk_walk.do_a_simple_walk_on_a_repo_with_different_sorting_modes;
 type
    TArray6 = array[0..5] of Integer;
 const
@@ -129,6 +129,6 @@ procedure Test0501_walk.simple_walk_test_0501;
 end;
 
 initialization
-   RegisterTest('From libgit2', Test0501_walk.Suite);
+   RegisterTest('From libgit2.t05-revwalk', Test05_revwalk_walk.NamedSuite('walk'));
 
 end.

TestsFromLibGit2/t06_index.pas

@@ -8,22 +8,25 @@ interface
 
 type
    Test06_index_read = class(TTestFromLibGit2)
-      procedure index_loadempty_test_0601;
-      procedure index_load_test_0601;
-      procedure index2_load_test_0601;
-      procedure index_find_test_0601;
-      procedure index_findempty_test_0601;
+      procedure load_an_empty_index;
+      procedure load_a_standard_index__default_test_index_;
+      procedure load_a_standard_index__git_git_index_;
+   end;
+
+   Test06_index_find = class(TTestFromLibGit2)
+      procedure find_an_entry_on_an_index;
+      procedure find_an_entry_in_an_empty_index;
    end;
 
    Test06_index_write = class(TTestFromLibGit2)
-      procedure index_write_test;
+      procedure write_an_index_back_to_disk;
    end;
 
 implementation
 
-{ Test0601_read }
+{ Test06_index_read }
 
-procedure Test06_index_read.index_loadempty_test_0601;
+procedure Test06_index_read.load_an_empty_index;
 var
    index: Pgit_index;
 begin
@@ -39,17 +42,14 @@ procedure Test06_index_read.index_loadempty_test_0601;
    git_index_free(index);
 end;
 
-procedure Test06_index_read.index_load_test_0601;
+procedure Test06_index_read.load_a_standard_index__default_test_index_;
 var
-   path: AnsiString;
    index: Pgit_index;
    i, offset: Integer;
    entries: PPgit_index_entry;
    e: Pgit_index_entry;
 begin
-   path := AnsiString(StringReplace(ExtractFilePath(ParamStr(0)) + TEST_INDEX_PATH, '/', '\', [rfReplaceAll]));
-
-   must_pass(git_index_open_bare(index, PAnsiChar(path)));
+   must_pass(git_index_open_bare(index, TEST_INDEX_PATH));
 
    CheckTrue(index.on_disk = 1);
 
@@ -74,7 +74,7 @@ procedure Test06_index_read.index_load_test_0601;
    git_index_free(index);
 end;
 
-procedure Test06_index_read.index2_load_test_0601;
+procedure Test06_index_read.load_a_standard_index__git_git_index_;
 var
    index: Pgit_index;
 begin
@@ -91,7 +91,9 @@ procedure Test06_index_read.index2_load_test_0601;
    git_index_free(index);
 end;
 
-procedure Test06_index_read.index_find_test_0601;
+{ Test06_index_find }
+
+procedure Test06_index_find.find_an_entry_on_an_index;
 var
    index: Pgit_index;
    i, idx: Integer;
@@ -108,7 +110,7 @@ procedure Test06_index_read.index_find_test_0601;
    git_index_free(index);
 end;
 
-procedure Test06_index_read.index_findempty_test_0601;
+procedure Test06_index_find.find_an_entry_in_an_empty_index;
 var
    index: Pgit_index;
    i, idx: Integer;
@@ -124,7 +126,9 @@ procedure Test06_index_read.index_findempty_test_0601;
    git_index_free(index);
 end;
 
-procedure Test06_index_write.index_write_test;
+{ Test06_index_write }
+
+procedure Test06_index_write.write_an_index_back_to_disk;
 var
    index: Pgit_index;
 begin
@@ -143,7 +147,8 @@ procedure Test06_index_write.index_write_test;
 end;
 
 initialization
-   RegisterTest('From libgit2.t06-index', Test06_index_read.Suite);
-   RegisterTest('From libgit2.t06-index', Test06_index_write.Suite);
+   RegisterTest('From libgit2.t06-index', Test06_index_read.NamedSuite('read'));
+   RegisterTest('From libgit2.t06-index', Test06_index_find.NamedSuite('find'));
+   RegisterTest('From libgit2.t06-index', Test06_index_write.NamedSuite('write'));
 
 end.

TestsFromLibGit2/t0801_readtag.pas

@@ -1,4 +1,4 @@
-unit t0802_write;
+unit t08_tag;
 
 interface
 
@@ -7,15 +7,52 @@ interface
    uTestsFromLibGit2, uGitForDelphi;
 
 type
-   Test0802_write = class(TTestFromLibGit2)
-      procedure tag_writeback_test_0802;
+   Test08_tag_read = class(TTestFromLibGit2)
+      procedure read_and_parse_a_tag_from_the_repository;
+   end;
+
+   Test08_tag_write = class(TTestFromLibGit2)
+      procedure write_a_tag_to_the_repository_and_read_it_again;
    end;
 
 implementation
 
-{ Test0802_write }
+{ Test08_tag_read }
+
+procedure Test08_tag_read.read_and_parse_a_tag_from_the_repository;
+var
+   repo: Pgit_repository;
+   tag1, tag2: Pgit_tag;
+   commit: Pgit_commit;
+   id1, id2, id_commit: git_oid;
+begin
+   must_pass(git_repository_open(repo, REPOSITORY_FOLDER));
+
+   git_oid_mkstr(@id1, tag1_id);
+   git_oid_mkstr(@id2, tag2_id);
+   git_oid_mkstr(@id_commit, tagged_commit);
+
+   must_pass(git_tag_lookup(tag1, repo, @id1));
+
+   CheckTrue(StrComp(git_tag_name(tag1), 'test') = 0);
+   CheckTrue(git_tag_type(tag1) = GIT_OBJ_TAG);
+
+   must_pass(git_tag_target(Pgit_object(tag2), tag1));
+   CheckTrue(tag2 <> nil);
+
+   CheckTrue(git_oid_cmp(@id2, git_tag_id(tag2)) = 0);
+
+   must_pass(git_tag_target(Pgit_object(commit), tag2));
+   CheckTrue(commit <> nil);
+
+   CheckTrue(git_oid_cmp(@id_commit, git_commit_id(commit)) = 0);
+
+   git_repository_free(repo);
+end;
+
+{ Test08_tag_write }
 
-procedure Test0802_write.tag_writeback_test_0802;
+procedure Test08_tag_write.write_a_tag_to_the_repository_and_read_it_again;
 const
    TAGGER_NAME:      PAnsiChar = 'Vicent Marti';
    TAGGER_EMAIL:     PAnsiChar = '[email protected]';
@@ -72,6 +109,7 @@ procedure Test0802_write.tag_writeback_test_0802;
 end;
 
 initialization
-   RegisterTest('From libgit2', Test0802_write.Suite);
+   RegisterTest('From libgit2.t08-tag', Test08_tag_read.NamedSuite('read'));
+   RegisterTest('From libgit2.t08-tag', Test08_tag_write.NamedSuite('write'));
 
 end.

TestsFromLibGit2/t0802_write.pas renamed to TestsFromLibGit2/t08_tag.pas

@@ -1,4 +1,4 @@
-unit t0901_readtree;
+unit t09_tree;
 
 interface
 
@@ -7,16 +7,19 @@ interface
    uTestsFromLibGit2, uGitForDelphi;
 
 type
-   Test0901_readtree = class(TTestFromLibGit2)
-      procedure tree_entry_access_test_0901;
-      procedure tree_read_test_0901;
+   Test09_tree_read = class(TTestFromLibGit2)
+      procedure access_randomly_the_entries_on_a_loaded_tree;
+      procedure read_a_tree_from_the_repository;
+   end;
+
+   Test09_tree_write = class(TTestFromLibGit2)
    end;
 
 implementation
 
-{ Test0901_readtree }
+{ Test09_tree_read }
 
-procedure Test0901_readtree.tree_entry_access_test_0901;
+procedure Test09_tree_read.access_randomly_the_entries_on_a_loaded_tree;
 var
    id: git_oid ;
    repo: Pgit_repository;
@@ -39,7 +42,7 @@ procedure Test0901_readtree.tree_entry_access_test_0901;
    git_repository_free(repo);
 end;
 
-procedure Test0901_readtree.tree_read_test_0901;
+procedure Test09_tree_read.read_a_tree_from_the_repository;
 var
    id: git_oid;
    repo: Pgit_repository;
@@ -66,6 +69,7 @@ procedure Test0901_readtree.tree_read_test_0901;
 end;
 
 initialization
-   RegisterTest('From libgit2', Test0901_readtree.Suite);
+   RegisterTest('From libgit2.t09-tree', Test09_tree_read.NamedSuite('read'));
+//   RegisterTest('From libgit2.t09-tree', Test09_tree_write.Suite('write')); // TODO THREADSAFE
 
 end.