Update to libgit at 7064938, v0.10.0

2 current issues:
  1. git_repository_close is not exposed
  2. git_strarray_free is not exposed, so there's no way to free memory
     from listing references.
These issues are fixed are the libgit2/development branch, but are not
merged back into libgit2/master yet.

Also, I removed the translation of the git_pack and git_revwalk structures
because they changed almost completely, and the internal details aren't
necessary for using the API.

Author: jasonpenny

LIBGIT2_sha

@@ -1,2 +1,2 @@
-# code based on github.com/libgit2/libgit2 sha:
-b760fbf539e1ce17ac2768da755834babf700b9a
+# code based on github.com/libgit2/libgit2 v0.10.0 sha:
+7064938bd5e7ef47bfd79a685a62c1e2649e2ce7

TestsFromLibGit2/t0402_details.pas

@@ -63,12 +63,12 @@ procedure Test0402_details.query_details_test_0402;
       p := 0;
       while p < parents do
       begin
-         parent := git_commit_parent(commit, p);
+         must_pass(git_commit_parent(parent, commit, p));
          CheckTrue(parent <> nil, 'parent <> nil');
          CheckTrue(git_commit_author(parent) <> nil, 'git_commit_author(parent) <> nil'); // is it really a commit?
          Inc(p);
       end;
-      CheckTrue(git_commit_parent(commit, parents) = nil, 'git_commit_parent(commit, parents) = nil');
+      must_fail(git_commit_parent(parent, commit, parents));
    end;
 
    git_repository_free(repo);

TestsFromLibGit2/t0501_walk.pas

@@ -51,12 +51,12 @@ procedure Test0501_walk.simple_walk_test_0501;
    commit_count = 6;
    result_bytes = 24;
 
-   function get_commit_index(commit: Pgit_commit): Integer;
+   function get_commit_index(raw_oid: Pgit_oid): Integer;
    var
       i: Integer;
       oid: array[0..39] of AnsiChar;
    begin
-      git_oid_fmt(oid, @commit.object_.id);
+      git_oid_fmt(oid, raw_oid);
 
       for i := 0 to commit_count - 1 do
       begin
@@ -71,27 +71,33 @@ procedure Test0501_walk.simple_walk_test_0501;
    end;
 
 
-   function test_walk(walk: Pgit_revwalk; start_from: Pgit_commit;
+   function test_walk(walk: Pgit_revwalk;
          flags: Integer; const possible_results: array of TArray6; results_count: Integer): Integer;
    var
-      commit: Pgit_commit;
+      oid: git_oid;
 
       ret, i: Integer;
       result_array: array [0..commit_count-1] of Integer;
    begin
+      git_revwalk_reset(walk);
       git_revwalk_sorting(walk, flags);
-      git_revwalk_push(walk, start_from);
 
       for i := 0 to commit_count - 1 do
          result_array[i] := -1;
 
       i := 0;
-      ret := git_revwalk_next(commit, walk);
+      ret := git_revwalk_next(@oid, walk);
       while (ret = GIT_SUCCESS) do
       begin
-         result_array[i] := get_commit_index(commit);
-         ret := git_revwalk_next(commit, walk);
+         result_array[i] := get_commit_index(@oid);
+         (*{
+            char str[41];
+            git_oid_fmt(str, &oid);
+            str[40] = 0;
+            printf("  %d) %s\n", i, str);
+         }*)
          Inc(i);
+         ret := git_revwalk_next(@oid, walk);
       end;
 
       for i := 0 to results_count - 1 do
@@ -110,38 +116,23 @@ procedure Test0501_walk.simple_walk_test_0501;
    id: git_oid;
    repo: Pgit_repository;
    walk: Pgit_revwalk;
-   head: Pgit_commit;
 begin
    repo := nil;
-   head := nil;
 
    must_pass(git_repository_open(repo, REPOSITORY_FOLDER));
 
    must_pass(git_revwalk_new(walk, repo));
 
    git_oid_mkstr(@id, commit_head);
+   git_revwalk_push(walk, @id);
 
-   must_pass(git_commit_lookup(head, repo, @id));
+   must_pass(test_walk(walk, GIT_SORT_TIME, commit_sorting_time, 1));
 
-   must_pass(test_walk(walk, head,
-            GIT_SORT_TIME,
-            commit_sorting_time, 1)
-   );
+   must_pass(test_walk(walk, GIT_SORT_TOPOLOGICAL, commit_sorting_topo, 2));
 
-   must_pass(test_walk(walk, head,
-            GIT_SORT_TOPOLOGICAL,
-            commit_sorting_topo, 2)
-   );
+   must_pass(test_walk(walk, GIT_SORT_TIME or GIT_SORT_REVERSE, commit_sorting_time_reverse, 1));
 
-   must_pass(test_walk(walk, head,
-            GIT_SORT_TIME or GIT_SORT_REVERSE,
-            commit_sorting_time_reverse, 1)
-   );
-
-   must_pass(test_walk(walk, head,
-            GIT_SORT_TOPOLOGICAL or GIT_SORT_REVERSE,
-            commit_sorting_topo_reverse, 2)
-   );
+   must_pass(test_walk(walk, GIT_SORT_TOPOLOGICAL or GIT_SORT_REVERSE, commit_sorting_topo_reverse, 2));
 
    git_revwalk_free(walk);
    git_repository_free(repo);

TestsFromLibGit2/t0801_readtag.pas

@@ -33,12 +33,12 @@ procedure Test0801_readtag.readtag_0801;
    CheckTrue(StrComp(git_tag_name(tag1), 'test') = 0);
    CheckTrue(git_tag_type(tag1) = GIT_OBJ_TAG);
 
-   tag2 := Pgit_tag(git_tag_target(tag1));
+   must_pass(git_tag_target(Pgit_object(tag2), tag1));
    CheckTrue(tag2 <> nil);
 
    CheckTrue(git_oid_cmp(@id2, git_tag_id(tag2)) = 0);
 
-   commit := Pgit_commit(git_tag_target(tag2));
+   must_pass(git_tag_target(Pgit_object(commit), tag2));
    CheckTrue(commit <> nil);
 
    CheckTrue(git_oid_cmp(@id_commit, git_commit_id(commit)) = 0);

TestsFromLibGit2/t10_refs.pas

@@ -47,6 +47,10 @@    Test10_refs_delete = class(TTestFromLibGit2)
       procedure delete_reference_deletes_both_packed_and_loose;
    end;
 
+   Test10_refs_list = class(TTestFromLibGit2)
+      procedure list_all_the_references_in_our_test_repo;
+   end;
+
 implementation
 
 const
@@ -616,6 +620,22 @@ procedure Test10_refs_delete.delete_reference_deletes_both_packed_and_loose;
    close_temp_repo(repo);
 end;
 
+{ Test10_refs_list }
+
+procedure Test10_refs_list.list_all_the_references_in_our_test_repo;
+var
+   repo: Pgit_repository;
+   ref_list: git_strarray;
+begin
+   must_pass(git_repository_open(repo, REPOSITORY_FOLDER));
+   must_pass(git_reference_listall(@ref_list, repo, GIT_REF_LISTALL));
+   must_be_true(ref_list.count = 8); //* 8 refs in total if we include the packed ones */
+
+   // TODO : git_strarray_free not exposed, no way to free memory
+//   git_strarray_free(ref_list);
+   git_repository_free(repo);
+end;
+
 initialization
    RegisterTest('From libgit2.t10-refs', Test10_refs_readtag.Suite);
    RegisterTest('From libgit2.t10-refs', Test10_refs_readsymref.Suite);
@@ -624,6 +644,7 @@ initialization
    RegisterTest('From libgit2.t10-refs', Test10_refs_packfile.Suite);
    RegisterTest('From libgit2.t10-refs', Test10_refs_rename.Suite);
    RegisterTest('From libgit2.t10-refs', Test10_refs_delete.Suite);
+   RegisterTest('From libgit2.t10-refs', Test10_refs_list.Suite);
 
 end.