Bump lowest tested K8s, adjust CEL

5.8+ has k8s 1.30 for its floor; OCP is 4.14 (k8s 1.27)
but 4.16 (k8s 1.29) works with this CEL.

Author: benjaminjb

.github/workflows/test.yaml

@@ -58,7 +58,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        kubernetes: [v1.33, v1.28]
+        kubernetes: [v1.33, v1.30]
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-go@v5
@@ -92,7 +92,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        kubernetes: [v1.33, v1.28]
+        kubernetes: [v1.33, v1.30]
     steps:
       - uses: actions/checkout@v5
       - uses: actions/setup-go@v5

config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml

@@ -16508,12 +16508,11 @@ spec:
                         type: object
                     type: object
                     x-kubernetes-validations:
-                    - message: logfile destination is restricted to '/tmp/logs/pgbouncer/'
-                        or an existing additional volume
-                      rule: '!has(self.config) || !has(self.config.global) || !has(self.config.global.logfile)
-                        || self.config.global.logfile.startsWith(''/tmp/logs/pgbouncer/'')
-                        || (has(self.volumes) && has(self.volumes.additional) && self.volumes.additional.exists(x,
-                        self.config.global.logfile.startsWith("/volumes/"+x.name)))'
+                    - message: config.global.logfile destination is restricted to
+                        '/tmp/logs/pgbouncer/' or an existing additional volume
+                      rule: self.?config.global.logfile.optMap(f, f.startsWith("/tmp/logs/pgbouncer/")
+                        || (self.?volumes.additional.hasValue() && self.volumes.additional.exists(v,
+                        f.startsWith("/volumes/" + v.name)))).orValue(true)
                 required:
                 - pgBouncer
                 type: object

pkg/apis/postgres-operator.crunchydata.com/v1/pgbouncer_types.go

@@ -9,10 +9,7 @@ import (
 )
 
 // PGBouncerPodSpec defines the desired state of a PgBouncer connection pooler.
-// +kubebuilder:validation:XValidation:rule=`!has(self.config) || !has(self.config.global) || !has(self.config.global.logfile) || self.config.global.logfile.startsWith('/tmp/logs/pgbouncer/') || (has(self.volumes) && has(self.volumes.additional) && self.volumes.additional.exists(x, self.config.global.logfile.startsWith("/volumes/"+x.name)))`,message=`logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume`
-// ---
-// TODO: the `.?` CEL syntax is unsupported in k8s 1.28, so we cannot use the optional field syntax
-// of `self.?config.global.logfile` and `self.?volumes.additional`
+// +kubebuilder:validation:XValidation:rule=`self.?config.global.logfile.optMap(f, f.startsWith("/tmp/logs/pgbouncer/") || (self.?volumes.additional.hasValue() && self.volumes.additional.exists(v, f.startsWith("/volumes/" + v.name)))).orValue(true)`,message=`config.global.logfile destination is restricted to '/tmp/logs/pgbouncer/' or an existing additional volume`
 type PGBouncerPodSpec struct {
 	v1beta1.PGBouncerPodSpec `json:",inline"`
 }