fix(lsp): handle wrapped settings in didChangeConfiguration (#9611)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: gaauwe

.changeset/three-candles-tan.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed a regression where Biome LSP could misread editor settings sent through `workspace/didChangeConfiguration` when the payload was wrapped in a top-level `biome` key. This caused `requireConfiguration` and related settings to be ignored in some editors.

crates/biome_configuration/src/generated/linter_options_check.rs

@@ -4660,6 +4660,77 @@ async fn should_acknowledge_changes_in_settings_when_pulling_diagnostics() -> Re
     Ok(())
 }
 
+#[tokio::test]
+async fn should_apply_wrapped_biome_settings_from_did_change_configuration() -> Result<()> {
+    let factory = ServerFactory::default();
+    let (service, client) = factory.create().into_inner();
+    let (stream, sink) = client.split();
+    let mut server = Server::new(service);
+
+    let (sender, mut receiver) = channel(CHANNEL_BUFFER_SIZE);
+    let reader = tokio::spawn(client_handler(stream, sink, sender));
+
+    server.initialize().await?;
+    server.initialized().await?;
+
+    server
+        .open_document("import { b, a } from \"./foo\";\n")
+        .await?;
+
+    let notification = wait_for_notification(&mut receiver, |n| n.is_publish_diagnostics()).await;
+
+    assert!(notification.is_some());
+
+    let notification = notification.expect("notification");
+    assert!(matches!(
+        notification,
+        ServerNotification::PublishDiagnostics(_)
+    ));
+    if let ServerNotification::PublishDiagnostics(result) = notification {
+        assert!(
+            !result.diagnostics.is_empty(),
+            "should contain diagnostics before applying wrapped biome settings"
+        );
+    }
+
+    sleep(Duration::from_millis(300)).await;
+
+    server
+        .notify(
+            "workspace/didChangeConfiguration",
+            DidChangeConfigurationParams {
+                settings: serde_json::json!({
+                    "biome": {
+                        "requireConfiguration": true,
+                        "configurationPath": null,
+                    }
+                }),
+            },
+        )
+        .await?;
+
+    let notification = wait_for_notification(&mut receiver, |n| n.is_publish_diagnostics()).await;
+
+    assert_eq!(
+        notification,
+        Some(ServerNotification::PublishDiagnostics(
+            PublishDiagnosticsParams {
+                uri: uri!("document.js"),
+                version: Some(0),
+                diagnostics: vec![],
+            }
+        )),
+        "diagnostics should be cleared after applying wrapped biome settings from didChangeConfiguration"
+    );
+
+    server.close_document().await?;
+
+    server.shutdown().await?;
+    reader.abort();
+
+    Ok(())
+}
+
 #[tokio::test]
 async fn pull_plugin_diagnostics_for_vue_files() -> Result<()> {
     let fs = MemoryFileSystem::default();

crates/biome_lsp/src/server.tests.rs

@@ -1175,6 +1175,10 @@ impl Session {
                 }
             }
             Some(settings) => {
+                let settings = settings
+                    .get(CONFIGURATION_SECTION)
+                    .cloned()
+                    .unwrap_or(settings);
                 let mut config = self.extension_settings.write().unwrap();
                 if let Err(err) = config.set_workspace_settings(settings) {
                     error!("Couldn't set client configuration: {}", err);