Fix ambiguous associated type usage on top of 0.20 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2021
gui1117
changed the title
Author
|
closed in favor of #110 I didn't know 0.20.1 was released, it would be great to have tags. |
Collaborator
|
I try to keep tags of all releases but I don't know how to enforce it as part of the publish rule :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funty 1.2 adds an associated const which conflicts with
BitMemory::BITSon type inference.This PR resolve the ambiguity by expliciting trait to use.
This is meant to be based on 0.20 but there is no branch (thus the missleading conflicts)
Also could we release a 0.20.2 with this patch ?