Refactor and clean

Author: ivanahuckova

names/names.py

@@ -11,21 +11,48 @@
 f.close()
 
 
-def comp(list1, list2):
+# # First pass solution provided
+# def compare_first(list_1, list_2):
+#     duplicates = []
+#     for item_1 in list_1:
+#         for item_2 in list_2:
+#             if item_1 == item_2:
+#                 duplicates.append(item_1)
+#     return duplicates
+
+# duplicates = compare_first(names_1, names_2)
+
+
+# # Second iteration
+# def compare_second(list_1, list_2):
+#     duplicates = []
+#     for item_1 in list_1:
+#         if item_1 in list_2:
+#             duplicates.append(item_1)
+#     return duplicates
+
+# duplicates = compare_second(names_1, names_2)
+
+
+# Third iteration
+def compare_third(list_1, list_2):
     duplicates = []
-    for val in list1:
-        if val in list2:
-            duplicates.append(val)
+    list_1_dictionary = {}
+
+    for item_1 in list_1:
+        list_1_dictionary[item_1] = item_1
+
+    for item_2 in list_2:
+        try:
+            if list_1_dictionary[item_2]:
+                duplicates.append(item_2)
+        except:
+            pass
     return duplicates
 
 
-duplicates = comp(names_1, names_2)
+duplicates = compare_third(names_1, names_2)
 
-# duplicates = []
-# for name_1 in names_1:
-#     for name_2 in names_2:
-#         if name_1 == name_2:
-#             duplicates.append(name_1)
 
 end_time = time.time()
 print(f"{len(duplicates)} duplicates:\n\n{', '.join(duplicates)}\n\n")