Skip to content

Mirror optimization of std::Vec::retain (rust-lang/rust#81126) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluss merged 3 commits into from
Mar 29, 2021
Merged

Mirror optimization of std::Vec::retain (rust-lang/rust#81126) #174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
345c6b4
Mirror optimization of std::Vec::retain (rust-lang/rust#81126)
niklasf Feb 19, 2021
c094906
Fix mutable reborrow
niklasf Feb 22, 2021
b82a6d4
FIX: Update .retain() optimization for const generics
bluss Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
FIX: Update .retain() optimization for const generics
  • Loading branch information
@bluss
bluss committed Mar 29, 2021
commit b82a6d497751995bd09d61f52a13e903fd047c94
6 changes: 3 additions & 3 deletions src/arrayvec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,14 +451,14 @@ impl<T, const CAP: usize> ArrayVec<T, CAP> {
let original_len = self.len();
unsafe { self.set_len(0) };

struct BackshiftOnDrop<'a, A: Array> {
v: &'a mut ArrayVec<A>,
struct BackshiftOnDrop<'a, T, const CAP: usize> {
v: &'a mut ArrayVec<T, CAP>,
processed_len: usize,
deleted_cnt: usize,
original_len: usize,
}

impl<A: Array> Drop for BackshiftOnDrop<'_, A> {
impl<T, const CAP: usize> Drop for BackshiftOnDrop<'_, T, CAP> {
fn drop(&mut self) {
if self.deleted_cnt > 0 {
unsafe {
Expand Down