Skip to content

Commit 0426f50

Browse files
committed
[ReactNative] Increase timeout and re-enable allocation tests
Summary: Two of the allocation were disabled due to eventual failures on Travis, but haven't failed internally nor locally. I'm bumping the time out and re-enabling them to see if that was the case.
1 parent 3cd9187 commit 0426f50

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Examples/UIExplorer/UIExplorerUnitTests/RCTAllocationTests.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#define RUN_RUNLOOP_WHILE(CONDITION) \
2424
_Pragma("clang diagnostic push") \
2525
_Pragma("clang diagnostic ignored \"-Wshadow\"") \
26-
NSDate *timeout = [[NSDate date] dateByAddingTimeInterval:0.1]; \
26+
NSDate *timeout = [[NSDate date] dateByAddingTimeInterval:5]; \
2727
while ((CONDITION) && [timeout timeIntervalSinceNow] > 0) { \
2828
[[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:timeout]; \
2929
} \
@@ -141,7 +141,7 @@ - (void)testModuleMethodsAreDeallocated
141141
XCTAssertNil(weakMethod, @"RCTModuleMethod should have been deallocated");
142142
}
143143

144-
- (void)DISABLED_testJavaScriptExecutorIsDeallocated // flaky: #8195866
144+
- (void)testJavaScriptExecutorIsDeallocated
145145
{
146146
__weak id<RCTJavaScriptExecutor> weakExecutor;
147147
@autoreleasepool {
@@ -157,7 +157,7 @@ - (void)DISABLED_testJavaScriptExecutorIsDeallocated // flaky: #8195866
157157
XCTAssertNil(weakExecutor, @"JavaScriptExecutor should have been released");
158158
}
159159

160-
- (void)disabled_testJavaScriptContextIsDeallocated
160+
- (void)testJavaScriptContextIsDeallocated
161161
{
162162
__weak id weakContext;
163163
@autoreleasepool {

0 commit comments

Comments
 (0)