Setup server constructor to look on path for location of browsermob-proxy executable. As well as looking for a file. Also added example code for using browsermob-proxy with chrome

Author: Jacob Schlather

browsermobproxy/server.py

@@ -9,7 +9,7 @@
 
 class Server(object):
 
-    def __init__(self, path, options={}):
+    def __init__(self, path = 'browsermob-proxy', options={}):
         """
         Initialises a Server object
 
@@ -19,11 +19,19 @@ def __init__(self, path, options={}):
                      More items will be added in the future.
                      This defaults to an empty dictionary
         """
+        path_var_sep = ':'
         if platform.system() == 'Windows':
+            path_var_sep = ';'
             if not path.endswith('.bat'):
                 path += '.bat'
 
-        if not os.path.isfile(path):
+        exec_not_on_path = True
+        for directory in os.environ['PATH'].split(path_var_sep):
+            if(os.path.isfile(os.path.join(directory, path))):
+                exec_not_on_path = False
+                break
+
+        if not os.path.isfile(path) and exec_not_on_path:
             raise Exception("Browsermob-Proxy binary couldn't be found in path"
                             " provided: %s" % path)
 

readme.md

@@ -31,6 +31,14 @@ driver.quit()
 
 ```
 
+for Chrome use
+
+```
+chrome_options = webdriver.ChromeOptions()
+chrome_options.add_argument("--proxy-server={0}".format(proxy.proxy))
+browser = webdriver.Chrome(chrome_options = chrome_options)
+```
+
 Running Tests
 -------------
 To run the tests in a CI environment, disable the ones that require human