Skip to content

Support "true" as string for ssl #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

Support "true" as string for ssl #2407

merged 1 commit into from
Nov 11, 2020

Conversation

brianc
Copy link
Owner

@brianc brianc commented Nov 10, 2020 •
edited
Loading

Fixes #2406

@brianc brianc mentioned this pull request Nov 10, 2020
Closed
@brianc brianc merged commit ebe412c into master Nov 11, 2020
@brianc brianc deleted the bmc/fix-2406 branch November 11, 2020 16:41
@vitaly-t
Copy link
Contributor

And breaks #2411?

@vitaly-t vitaly-t mentioned this pull request Nov 13, 2020
Closed
@brianc
Copy link
Owner Author

brianc commented Nov 13, 2020

And breaks #2411?

This couldn't have caused #2411 as this hasn't been released to npm yet.

@vitaly-t vitaly-t mentioned this pull request Nov 13, 2020
Closed
This was referenced Mar 17, 2021
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 8.5.0 fails with ssl: true
2 participants
@brianc @vitaly-t